Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Move Monitor list histogram to async search #113528

Merged
merged 8 commits into from
Oct 7, 2021
Merged

[Uptime] Move Monitor list histogram to async search #113528

merged 8 commits into from
Oct 7, 2021

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Sep 30, 2021 •
edited
Loading

Summary

Fix elastic/uptime#364

Testing

  • Make sure down histogram appears in monitor list

@shahzad31 shahzad31 changed the title [Uptime] Monitor list histogram [Uptime] Move Monitor list histogram to async search Oct 4, 2021
@shahzad31 shahzad31 marked this pull request as ready for review October 5, 2021 15:24
@shahzad31 shahzad31 requested a review from a team as a code owner October 5, 2021 15:24
@shahzad31 shahzad31 self-assigned this Oct 5, 2021
@shahzad31 shahzad31 added v7.16.0 v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Oct 5, 2021
@dominiqueclarke
Copy link
Contributor

@shahzad31 aside from testing regression, is there any progression tested needed here with searchable snapshots?

@shahzad31
Copy link
Contributor Author

@shahzad31 aside from testing regression, is there any progression tested needed here with searchable snapshots?
@dominiqueclarke No, that isnt part of scope of this issue.

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
uptime 658 660 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 569.1KB 570.9KB +1.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

dominiqueclarke
dominiqueclarke approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, histogram looks good.

Screen Shot 2021-10-06 at 12 54 30 PM

@shahzad31 shahzad31 merged commit e388648 into elastic:master Oct 7, 2021
@shahzad31 shahzad31 deleted the mon-list-hist branch October 7, 2021 07:48
@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 7, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Oct 7, 2021
@shahzad31 @kibanamachine
[Uptime] Move Monitor list histogram to async search (elastic#113528)
4c5d418 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Oct 7, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 8, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 11, 2021
kibanamachine added a commit that referenced this pull request Oct 11, 2021
@kibanamachine @shahzad31
[Uptime] Move Monitor list histogram to async search (#113528) (#114230)
29c3b96 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@shahzad31 shahzad31

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move monitor list histogram API to Async search
4 participants
@shahzad31 @elasticmachine @dominiqueclarke @kibanamachine