Fixes problem with one chart plotted for multiple y axis when migrating from an old SO #112972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ong from an old SO
stratoula
changed the title
|
@elasticmachine merge upstream |
stratoula
added
Feature:XYAxis
|
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
dej611
reviewed
Oct 1, 2021
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
dej611
approved these changes
Oct 6, 2021
stratoula
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 6, 2021
…ng from an old SO (elastic#112972) * Fixes problem with one chart plotted for multiple y axis when migrationg from an old SO * Add unit tests * Address PR comments Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 6, 2021
…ng from an old SO (#112972) (#114098) * Fixes problem with one chart plotted for multiple y axis when migrationg from an old SO * Add unit tests * Address PR comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #112345.
Which is the problem
The problem is that there are some very old SOs that don't have the following params properties:
An example is:
Here is a ndjson for testing:
testing.ndjson.zip
Solution
The reason that the charts are not rendered (only one is rendered) is because we don't have the seriesParams array in our params. For this reason, the default is applied and only the first chart is rendered. I fixed that by extracting the seriesParams by the aggs property.
But this doesn't solve all the problems. For example if the user has defined different yaxis which means multiple valueAxes, when upgrade, they will render in one axis (the left one). The reason that I can't fix it is that I don't know how the configuration was back then.
Vislib
The vislib implementation plots all charts but still doesn't solve the problem with the multiple y-axis.
Checklist