[Lens] Thresholds: moving a threshold to another group should carry also its styling #112853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dej611
added
Team:Visualizations
|
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
|
@elasticmachine merge upstream |
|
Updated PR to copy styles also in the duplicate scenario. |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
mbondyra
approved these changes
Sep 29, 2021
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 29, 2021
…lso its styling (elastic#112853) * 🐛 When dragging a threshold to another group carry also its styling * ✅ Add functional test * ✨ Make duplicate carry style too * ✅ Add functional test for duplicate use case * 🐛 Fix table duplication issue Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 29, 2021
…lso its styling (#112853) (#113451) * 🐛 When dragging a threshold to another group carry also its styling * ✅ Add functional test * ✨ Make duplicate carry style too * ✅ Add functional test for duplicate use case * 🐛 Fix table duplication issue Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Marco Liberati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #112799
This PR addresses the specific behaviour of moving a dimension from one group to another, where only datasource data was copied, ignoring visualization styling.
The new code is now adding one more case to the
previousColumnassignment, passing thecolumnIdalso in the case of move.I thought about limiting this specific behaviour only to threshold data layers, but I see no particular harm for data layer as well: from my testing
datatable(the only vis using thepreviousColumnparameter)had no issue with this changehad some issues with this change, so now groups can express with a flag whether duplication action requires the previous column or not.Also: wanted to add some unit tests but probably with all the required mocking it is not worth. Added a functional test ✅ .
Checklist
Delete any items that are not applicable to this PR.