Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy pass 3 #112815

Merged
merged 5 commits into from
Sep 22, 2021
Merged

Copy pass 3 #112815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b47c8b
Remove Source config section description
yakhinvadim Sep 22, 2021
ff48e29
Update copy
yakhinvadim Sep 22, 2021
21a3bff
Update i18n
yakhinvadim Sep 22, 2021
7f47dab
Merge branch 'master' into copy-pass-3
kibanamachine Sep 22, 2021
f322f66
Merge branch 'master' into copy-pass-3
kibanamachine Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...public/applications/workplace_search/views/content_sources/components/source_settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ import {
SOURCE_SETTINGS_DESCRIPTION,
SOURCE_NAME_LABEL,
SOURCE_CONFIG_TITLE,
SOURCE_CONFIG_DESCRIPTION,
SOURCE_CONFIG_LINK,
SOURCE_REMOVE_TITLE,
SOURCE_REMOVE_DESCRIPTION,
Expand Down Expand Up @@ -206,7 +205,7 @@ export const SourceSettings: React.FC = () => {
</form>
</ContentSection>
{showConfig && (
<ContentSection title={SOURCE_CONFIG_TITLE} description={SOURCE_CONFIG_DESCRIPTION}>
<ContentSection title={SOURCE_CONFIG_TITLE}>
<SourceConfigFields
clientId={clientId}
clientSecret={clientSecret}
Expand Down
9 changes: 1 addition & 8 deletions ...enterprise_search/public/applications/workplace_search/views/content_sources/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,13 +306,6 @@ export const SOURCE_CONFIG_TITLE = i18n.translate(
}
);

export const SOURCE_CONFIG_DESCRIPTION = i18n.translate(
'xpack.enterpriseSearch.workplaceSearch.sources.config.description',
{
defaultMessage: 'Edit content source connector settings to change.',
}
);

export const SYNC_MANAGEMENT_TITLE = i18n.translate(
'xpack.enterpriseSearch.workplaceSearch.contentSources.syncManagementTitle',
{
Expand Down Expand Up @@ -358,7 +351,7 @@ export const SYNC_MANAGEMENT_CONTENT_EXTRACTION_LABEL = i18n.translate(
export const SOURCE_CONFIG_LINK = i18n.translate(
'xpack.enterpriseSearch.workplaceSearch.sources.config.link',
{
defaultMessage: 'Edit content source connector settings',
defaultMessage: 'Edit connector settings',
}
);

Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10226,7 +10226,6 @@
"xpack.enterpriseSearch.workplaceSearch.sources.additionalConfig.heading": "追加の構成が必要",
"xpack.enterpriseSearch.workplaceSearch.sources.applicationLinkTitles.github": "GitHub開発者ポータル",
"xpack.enterpriseSearch.workplaceSearch.sources.baseUrlTitles.github": "GitHub Enterprise URL",
"xpack.enterpriseSearch.workplaceSearch.sources.config.description": "変更するコンテンツソースコネクター設定を編集します。",
"xpack.enterpriseSearch.workplaceSearch.sources.config.link": "コンテンツソースコネクター設定を編集",
"xpack.enterpriseSearch.workplaceSearch.sources.config.title": "コンテンツソース構成",
"xpack.enterpriseSearch.workplaceSearch.sources.configuration.title": "構成",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10327,7 +10327,6 @@
"xpack.enterpriseSearch.workplaceSearch.sources.additionalConfig.heading": "需要其他配置",
"xpack.enterpriseSearch.workplaceSearch.sources.applicationLinkTitles.github": "GitHub 开发者门户",
"xpack.enterpriseSearch.workplaceSearch.sources.baseUrlTitles.github": "GitHub Enterprise URL",
"xpack.enterpriseSearch.workplaceSearch.sources.config.description": "编辑要更改的内容源连接器设置。",
"xpack.enterpriseSearch.workplaceSearch.sources.config.link": "编辑内容源连接器设置",
"xpack.enterpriseSearch.workplaceSearch.sources.config.title": "内容源配置",
"xpack.enterpriseSearch.workplaceSearch.sources.configuration.title": "配置",
Expand Down