Fixes flakiness in timelion viz functional test #112805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
stratoula
added
release_note:skip
|
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
dej611
approved these changes
Sep 22, 2021
stratoula
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 22, 2021
* Fixes flakiness in timelion viz functional test * Add sleep
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 22, 2021
* Fixes flakiness in timelion viz functional test * Add sleep Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #112731
This test failed also locally (if you run it alone). The problem is that the syntax of timelion is quite sensitive, especially when it is tested on a functional test like this (the whole expression is added at once and we wait for the fields popover to be displayed)
I added a sleep to give some time to the suggestions to load and also have fixed the timelion expression syntax. I saw that
timefield=@timestamp ,split=was flaky. Sometimes, the suggestions list were retrieved wrongly (instead of retrieving the suggestions it retrieved the word split).Flaky runner (50 times): https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1912/
Flaky runner (50 times): https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1915/