-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] update endpoint list api to support united index #112758
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,8 @@ | |
*/ | ||
|
||
import { Dispatch } from 'redux'; | ||
import semverGte from 'semver/functions/gte'; | ||
|
||
import { CoreStart, HttpStart } from 'kibana/public'; | ||
import { | ||
ActivityLog, | ||
|
@@ -40,6 +42,7 @@ import { | |
getMetadataTransformStats, | ||
isMetadataTransformStatsLoading, | ||
getActivityLogIsUninitializedOrHasSubsequentAPIError, | ||
endpointPackageVersion, | ||
} from './selectors'; | ||
import { | ||
AgentIdsPendingActions, | ||
|
@@ -61,6 +64,7 @@ import { | |
HOST_METADATA_LIST_ROUTE, | ||
BASE_POLICY_RESPONSE_ROUTE, | ||
metadataCurrentIndexPattern, | ||
METADATA_UNITED_INDEX, | ||
} from '../../../../../common/endpoint/constants'; | ||
import { IIndexPattern, Query } from '../../../../../../../../src/plugins/data/public'; | ||
import { | ||
|
@@ -85,13 +89,26 @@ export const endpointMiddlewareFactory: ImmutableMiddlewareFactory<EndpointState | |
coreStart, | ||
depsStart | ||
) => { | ||
async function fetchIndexPatterns(): Promise<IIndexPattern[]> { | ||
// this needs to be called after endpointPackageVersion is loaded (getEndpointPackageInfo) | ||
// or else wrong pattern might be loaded | ||
async function fetchIndexPatterns( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. use the endpoint package version to determine which index the kql bar should use for auto completion |
||
state: ImmutableObject<EndpointState> | ||
): Promise<IIndexPattern[]> { | ||
const packageVersion = endpointPackageVersion(state) ?? ''; | ||
const parsedPackageVersion = packageVersion.includes('-') | ||
? packageVersion.substring(0, packageVersion.indexOf('-')) | ||
: packageVersion; | ||
const minUnitedIndexVersion = '1.2.0'; | ||
const indexPatternToFetch = semverGte(parsedPackageVersion, minUnitedIndexVersion) | ||
? METADATA_UNITED_INDEX | ||
: metadataCurrentIndexPattern; | ||
|
||
const { indexPatterns } = depsStart.data; | ||
const fields = await indexPatterns.getFieldsForWildcard({ | ||
pattern: metadataCurrentIndexPattern, | ||
pattern: indexPatternToFetch, | ||
}); | ||
const indexPattern: IIndexPattern = { | ||
title: metadataCurrentIndexPattern, | ||
title: indexPatternToFetch, | ||
fields, | ||
}; | ||
return [indexPattern]; | ||
|
@@ -379,7 +396,7 @@ async function endpointDetailsListMiddleware({ | |
}: { | ||
store: ImmutableMiddlewareAPI<EndpointState, AppAction>; | ||
coreStart: CoreStart; | ||
fetchIndexPatterns: () => Promise<IIndexPattern[]>; | ||
fetchIndexPatterns: (state: ImmutableObject<EndpointState>) => Promise<IIndexPattern[]>; | ||
}) { | ||
const { getState, dispatch } = store; | ||
|
||
|
@@ -441,7 +458,7 @@ async function endpointDetailsListMiddleware({ | |
// get index pattern and fields for search bar | ||
if (patterns(getState()).length === 0) { | ||
try { | ||
const indexPatterns = await fetchIndexPatterns(); | ||
const indexPatterns = await fetchIndexPatterns(getState()); | ||
if (indexPatterns !== undefined) { | ||
dispatch({ | ||
type: 'serverReturnedMetadataPatterns', | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding an optional path to the fields since we copy .fleet-agents mapping but are additionally nesting it