Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Log deprecation warnings for plugins which won't be disable-able in 8.0 (#112602) #112728

Merged
merged 12 commits into from
Sep 22, 2021
Merged

[7.x] Log deprecation warnings for plugins which won't be disable-able in 8.0 (#112602) #112728

merged 12 commits into from
Sep 22, 2021

Conversation

lukeelmers
Copy link
Member

@lukeelmers lukeelmers commented Sep 21, 2021 •
edited
Loading

Manually backports #112602 to 7.x

Doing this for testing purposes so that folks can pull down the branch and review how it looks with the Upgrade Assistant.

Screen Shot 2021-09-21 at 2 19 58 PM

@lukeelmers lukeelmers self-assigned this Sep 21, 2021
@lukeelmers lukeelmers mentioned this pull request Sep 21, 2021
Merged
@lukeelmers lukeelmers marked this pull request as ready for review September 21, 2021 20:04
@lukeelmers
Copy link
Member Author

@elasticmachine merge upstream

@lukeelmers lukeelmers enabled auto-merge (squash) September 22, 2021 17:54
@lukeelmers lukeelmers changed the title [7.x] Log deprecation warnings for plugins which will no longer be disable-able in 8.0 (#112602) [7.x] Log deprecation warnings for plugins which won't be disable-able in 8.0 (#112602) Sep 22, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
core 1015 1021 +6

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 25.0KB 24.9KB -41.0B
Unknown metric groups

API count

id before after diff
core 2286 2294 +8

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukeelmers

@lukeelmers lukeelmers merged commit ef8518d into elastic:7.x Sep 22, 2021
@lukeelmers lukeelmers deleted the feat/disableable-plugins-7.x branch September 22, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lukeelmers lukeelmers

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukeelmers @kibanamachine