Resolving issue with TSVB resizeHandler not triggering renderChart #11259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when viewing some time series visual builder panels on a Dashboard and doing a hard-refresh, all the calls to flot_chart.js's renderChart method were early returning because the resize.clientHeight and resize.clientWidth were 0; then a call to handleResize was coming and it wasn't triggering the initial drawing of the chart. This modifies the logic to keep track of whether the chart has been rendered yet, and if it hasn't calls renderChart from the resize handler.
kobelb
added a commit
that referenced
this pull request
Apr 14, 2017
…11259) Previously, when viewing some time series visual builder panels on a Dashboard and doing a hard-refresh, all the calls to flot_chart.js's renderChart method were early returning because the resize.clientHeight and resize.clientWidth were 0; then a call to handleResize was coming and it wasn't triggering the initial drawing of the chart. This modifies the logic to keep track of whether the chart has been rendered yet, and if it hasn't calls renderChart from the resize handler.
kobelb
added a commit
that referenced
this pull request
Apr 14, 2017
…11259) Previously, when viewing some time series visual builder panels on a Dashboard and doing a hard-refresh, all the calls to flot_chart.js's renderChart method were early returning because the resize.clientHeight and resize.clientWidth were 0; then a call to handleResize was coming and it wasn't triggering the initial drawing of the chart. This modifies the logic to keep track of whether the chart has been rendered yet, and if it hasn't calls renderChart from the resize handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when viewing some time series visual builder panels on a
Dashboard and doing a hard-refresh, all the calls to flot_chart.js's
renderChart method were early returning because the resize.clientHeight
and resize.clientWidth were 0; then a call to handleResize was coming
and it wasn't triggering the initial drawing of the chart. This modifies
the logic to keep track of whether the chart has been rendered yet, and
if it hasn't calls renderChart from the resize handler.
Resolves #11258