[Global search] Prevent unnecessary /internal/global_search/find http call at startup #112535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
shahzad31
force-pushed
the
fix-global-search
branch
from
5ee351a to
f672735
Compare
shahzad31
changed the title
shahzad31
changed the title
shahzad31
added
release_note:skip
|
@elasticmachine merge upstream |
shahzad31
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Oct 28, 2021
shahzad31
added
the
auto-backport
|
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 28, 2021
… call at startup (elastic#112535) Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 28, 2021
… call at startup (elastic#112535) Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 28, 2021
… call at startup (#112535) (#116628) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Shahzad <[email protected]>
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
pgayvallet
pushed a commit
that referenced
this pull request
Nov 2, 2021
… call at startup (#112535) (#116627) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Shahzad <[email protected]>
kibanamachine
removed
the
backport missing
This was referenced Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #78785
Prevented unnecessary
/internal/global_search/findhttp call at startup, calls will be made only when components has been in focus.This was causing two http api calls each time kibana loaded, regardless of the page you are.
Overhauled tests, it seems like previous tests were broken, since input focus wasn't working in tests.