-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] [Synthetics Integration] add new advanced options #112454
[Uptime] [Synthetics Integration] add new advanced options #112454
Conversation
Pinging @elastic/uptime (Team:uptime) |
Is it worth clarifying that these can be comma separated lists of tags/filters? Also, is it worth adding an example as a placeholder attribute (something like |
@paulb-elastic |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
…2-synthetics-integration-new-advanced-options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nit comments about copy but the smoke testing worked for me, and rest LGTM
helpText={ | ||
<FormattedMessage | ||
id="xpack.uptime.createPackagePolicy.stepConfigure.browserAdvancedSettings.journeyFiltersMatch.helpText" | ||
defaultMessage="Run only journeys with a name or tags that matches the provided glob." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaultMessage="Run only journeys with a name or tags that matches the provided glob." | |
defaultMessage="Run only journeys with a name or tag that matches the provided glob." |
Think this is cleaner copy.
helpText={ | ||
<FormattedMessage | ||
id="xpack.uptime.createPackagePolicy.stepConfigure.browserAdvancedSettings.journeyFiltersTags.helpText" | ||
defaultMessage="Run only journeys with the given tag(s), or globs." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaultMessage="Run only journeys with the given tag(s), or globs." | |
defaultMessage="Run only journeys with the given tags, or globs." |
Think we can skip this since globs is plural.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
description={ | ||
<FormattedMessage | ||
id="xpack.uptime.createPackagePolicy.stepConfigure.browserAdvancedSettings.filtering.description" | ||
defaultMessage="Filter tests using match or tags options." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should clarify somewhere that this is for when you're running a suite of tests vs using the recorder of inline. I was a bit confused. I also think perhaps we should look at a different word than filter. Something about "Selective Tests" "Use this option to apply these monitor settings to a subset of the tests in your suite". (or something along those lines)
As I understand this, you're not really filtering per-se, you more choosing a subset to apply an action to (in this case, the monitor frequency, name etc that you set above) WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drewpost That makes sense. I can hide these settings when inline or recorder is selected.
I think the statement about "not really filtering" is generally correct, though it will filter in the sense that only that subset will be run. Maybe add an additional sentence: "Only the configured subset will be run by this monitor."
…ons' of https://github.com/dominiqueclarke/kibana into feature/109732-synthetics-integration-new-advanced-options
@elasticmachine merge upstream |
…ons' of https://github.com/dominiqueclarke/kibana into feature/109732-synthetics-integration-new-advanced-options
@elasticmachine merge upstream |
…ons' of https://github.com/dominiqueclarke/kibana into feature/109732-synthetics-integration-new-advanced-options
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - reviewed that the filters field will only appear when you have entered a zip URL.
…12454) * refactor common fields * add ignore_https_errors and journey filters options * adjust formatters and normalizers * adjust content and hide fields when zip url is not defined * adjust content again * update tests * adjust tests * adjust tests Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…114685) * refactor common fields * add ignore_https_errors and journey filters options * adjust formatters and normalizers * adjust content and hide fields when zip url is not defined * adjust content again * update tests * adjust tests * adjust tests Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Dominique Clarke <[email protected]>
Fixes #109732
This PR adds UI components for the
ignore_https_errors
andfilter_journeys
options.This PR also refactors some of the common options across monitor type for better code reuse, and renames a few files.
Testing
Setting up your e2e testing environment
Overview: You will need to run a local version of kibana and package registry to test pending changes, but will use
elastic-package
to run a snapshot view of elasticsearch, fleet-server, and elastic-agent. Since fleet server relies on kibana, we'll also useelastic-package
to start a snapshot view of kibana exclusively for bootstrapping fleet-server, but will point our local version of kibana to a separate port. So we'll be running two versions of Kibana.kibana.dev.yml
settings, add removekibana.index
andxpack.task_manager.index
to remove legacy multitenancy features. This ensures that both our instances of Kibana can share saved objects related to fleet and agent. Also, add the following keys:env BUILD_TS_REFS_DISABLE=true yarn kbn bootstrap && yarn start
packages/synthetics
in the repo directory. Runelastic-package clean
, thenelastic-package build
.go get github.com/elastic/elastic-package
elastic-package stack up -d -v --services "elasticsearch,fleet-server,elastic-agent,package-registry" --version 8.0.0-SNAPSHOT
in thepackages/synthetics
directory. This will start up elasticsearch, fleet-server, elastic-agent, package registry AND kibana. This is because fleet-server requires kibana for bootstrapping.kibana_system
usercurl -u elastic:changeme -X POST "http://localhost:9200/_security/user/kibana_system/_password?pretty" -H 'Content-Type: application/json' -d' { "password" : "changeme" } '
Testing filter tags
fleet/integrations/synthetics-0.3.1/add-integration
https://github.com/elastic/synthetics-demo/archive/refs/heads/main.zip
, foldere-commerce
, params{ "url": "https://elastic-synthetics.vercel.app/" }
5. Save the integration and navigate to Uptime 6. Verify that only this journey was ran (the name may be different depending on what you named your policy
Testing filter match
fleet/integrations/synthetics-0.3.1/add-integration
https://github.com/elastic/synthetics-demo/archive/refs/heads/main.zip
, foldere-commerce
, params{ "url": "https://elastic-synthetics.vercel.app/" }
5. Save the integration and navigate to Uptime 6. Verify that only this journey was ran (the name may be different depending on what you named your policy
Testing ignore http errors
fleet/integrations/synthetics-0.3.1/add-integration
5. Save the integration and navigate to Uptime 6. Click on the journey to go to the journey details page 7. Verify that the wrong.host.badssl image appears, indicating that an ssl error was ignored