Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] fixed big header #112380

Merged
merged 1 commit into from
Sep 16, 2021
Merged

[Fleet] fixed big header #112380

merged 1 commit into from
Sep 16, 2021

Conversation

juliaElastic
Copy link
Contributor

Summary

Fix for #112374, side effect for #111725

Reduced size of header by setting max height of icon panel. Still bigger than before, to avoid overlapping text below.

image

@juliaElastic juliaElastic requested a review from a team as a code owner September 16, 2021 07:35
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic juliaElastic added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 v7.15.0 labels Sep 16, 2021
@juliaElastic juliaElastic linked an issue Sep 16, 2021 that may be closed by this pull request
[Fleet]: Extra large header under Integrations tab on 7.15 BC-6. #112374
Closed
@juliaElastic juliaElastic enabled auto-merge (squash) September 16, 2021 08:15
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1022.0KB 1022.2KB +220.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@juliaElastic juliaElastic merged commit 14c8973 into elastic:master Sep 16, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 16, 2021
@juliaElastic @kibanamachine
fixed big header (elastic#112380)
871e70f
@kibanamachine kibanamachine mentioned this pull request Sep 16, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 16, 2021
@juliaElastic @kibanamachine
fixed big header (elastic#112380)
a66e87a
@kibanamachine kibanamachine mentioned this pull request Sep 16, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

@juliaElastic juliaElastic deleted the fix-header branch September 16, 2021 10:00
kibanamachine added a commit that referenced this pull request Sep 16, 2021
@kibanamachine @juliaElastic
fixed big header (#112380) (#112392)
6622a83 
Co-authored-by: juliaElastic <[email protected]>
kibanamachine added a commit that referenced this pull request Sep 16, 2021
@kibanamachine @juliaElastic
fixed big header (#112380) (#112393)
d6e2080 
Co-authored-by: juliaElastic <[email protected]>
@amolnater-qasource
Copy link

Hi @EricDavisX
We are validating this PR in lieu of reported issue at #112374
We have revalidated this on latest 7.15.0 Snapshot and found it fixed now.

Observations:

  • Header is adjusted as it was earlier on lower BC versions.

Screenshot:
1

Build details:
Build: 44052
Commit: 28390b1

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hop-dev hop-dev hop-dev approved these changes

Assignees

@juliaElastic juliaElastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet]: Extra large header under Integrations tab on 7.15 BC-6.
5 participants
@juliaElastic @elasticmachine @kibanamachine @amolnater-qasource @hop-dev