Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix data loss mssage #112294

Merged
merged 1 commit into from
Sep 16, 2021
Merged

[Lens] Fix data loss mssage #112294

merged 1 commit into from
Sep 16, 2021

Conversation

flash1293
Copy link
Contributor

Fixes #72634

As discussed in the issue

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.16.0 labels Sep 15, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.6MB 1.6MB +2.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review September 16, 2021 07:41
@flash1293 flash1293 requested a review from a team as a code owner September 16, 2021 07:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@flash1293 flash1293 added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 16, 2021
@flash1293 flash1293 merged commit 411d232 into elastic:master Sep 16, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 16, 2021
@flash1293 @kibanamachine
fix data loss mssage (elastic#112294)
b1333b9
@kibanamachine kibanamachine mentioned this pull request Sep 16, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 16, 2021
@kibanamachine @flash1293
fix data loss mssage (#112294) (#112389)
198ba34 
Co-authored-by: Joe Reuter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Let user know why switching to another chart causes losing the configuration
5 participants
@flash1293 @kibanamachine @elasticmachine @dej611 @mbondyra