Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Remove new badge from Dependencies link in the solution navigation #112269

Merged
merged 1 commit into from
Sep 16, 2021
Merged

[APM] Remove new badge from Dependencies link in the solution navigation #112269

merged 1 commit into from
Sep 16, 2021

Conversation

MiriamAparicio
Copy link
Contributor

Summary

Closes #108488

@MiriamAparicio MiriamAparicio requested a review from a team as a code owner September 15, 2021 13:16
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Sep 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@MiriamAparicio MiriamAparicio added release_note:skip Skip the PR/issue when compiling release notes v7.16.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Sep 15, 2021
@formgeist formgeist mentioned this pull request Sep 15, 2021
Closed
@formgeist formgeist changed the title [APM] Remove new badge from Backends link in the solution navigation [APM] Remove new badge from Dependencies link in the solution navigation Sep 15, 2021
@formgeist
Copy link
Contributor

@MiriamAparicio just updated the title to reflect the real label of the link 👍

@MiriamAparicio MiriamAparicio force-pushed the remove-badge-from-be-link branch from a239ba2 to 41394df Compare September 15, 2021 14:38
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 46.2KB 46.2KB -16.0B

History

  • 💔 Build #153534 failed a239ba26818ca58b7b378acd9f96f9781c9cce52

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MiriamAparicio MiriamAparicio merged commit e4dc455 into elastic:master Sep 16, 2021
@MiriamAparicio MiriamAparicio deleted the remove-badge-from-be-link branch September 16, 2021 09:56
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 16, 2021
@MiriamAparicio @kibanamachine
[APM] Remove new badge from Backends link in the solution navigation (e…
3841de1 
…lastic#112269)
@kibanamachine kibanamachine mentioned this pull request Sep 16, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 16, 2021
@kibanamachine @MiriamAparicio
[APM] Remove new badge from Backends link in the solution navigation (#…
9f0fd25 
…112269) (#112394)

Co-authored-by: Miriam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Remove "new" badge from Dependencies link in the solution navigation
5 participants
@MiriamAparicio @elasticmachine @formgeist @kibanamachine @sorenlouv