Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] add missing mb field #112251

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

estermv
Copy link
Contributor

@estermv estermv commented Sep 15, 2021

Summary

Fixes #110719

The bug was introduced in #96205 for 7.14, causing the ES query to be incorrect as we were missing the field in one of the aggregations:

Screenshot 2021-09-15 at 16 01 15

Reviewer notes

  • I'm not sure if this is the correct field from where we have to get the data. I used the same field as defined here because it has the same field.
  • The field added is used here.

Checklist

Delete any items that are not applicable to this PR.

@estermv estermv added release_note:fix v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring v7.14.0 v7.15.0 v7.16.0 labels Sep 15, 2021
@estermv estermv marked this pull request as ready for review September 15, 2021 14:07
@estermv estermv requested a review from a team as a code owner September 15, 2021 14:07
@estermv estermv requested review from a team September 15, 2021 14:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those +1,178,984 −240,770 diffs. They'll get you every time :)

Let me know if there are any testing steps you'd recommend, otherwise LGTM.

@estermv estermv merged commit 59ede3e into elastic:master Sep 16, 2021
estermv added a commit to estermv/kibana that referenced this pull request Sep 16, 2021
estermv added a commit to estermv/kibana that referenced this pull request Sep 16, 2021
estermv added a commit that referenced this pull request Sep 16, 2021
estermv added a commit that referenced this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Clicking on pipelines tab from logstash node view responds with socket hangup error
4 participants