Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Datatable] Removes the old implementation (#111339) #112059

Merged
merged 4 commits into from
Sep 14, 2021

Conversation

stratoula
Copy link
Contributor

Backports the following commits to 7.x:

* [Datatable] Removes the angular implementation

* Fix i18n errors

* Fix types

* Remove unecessary funtional tests

* Fix documentation

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	scripts/functional_tests.js
@stratoula stratoula enabled auto-merge (squash) September 14, 2021 09:05
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Sep 14, 2021
@elastic elastic deleted a comment from kibanamachine Sep 14, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTable 76 40 -36

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTable 104.0KB 28.9KB -75.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeTable 8.5KB 24.2KB +15.7KB
Unknown metric groups

async chunk count

id before after diff
visTypeTable 5 2 -3

References to deprecated APIs

id before after diff
visTypeTable 11 1 -10

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit fc2feaf into elastic:7.x Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants