Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Buildkite] Pull Request pipeline #112029

Merged
merged 5 commits into from
Oct 1, 2021

Conversation

brianseeders
Copy link
Contributor

@brianseeders brianseeders commented Sep 13, 2021

[skip-ci]

Implement the remaining items to enable pull request pipelines in Buildkite. A lot of work was done elsewhere, e.g. in https://github.com/elastic/kibana-buildkite-build-bot for PR comments.

This PR does not enable PR comments for all PRs or disable PRs in Jenkins. However, it does allow PRs to opt-in to Buildkite PRs (like this one!) by:

  • Adding [skip-ci] to the description, to make Jenkins not run CI
  • Adding the buildkite-ci label

At that point, the PR will function as normal, except that it will run in Buildkite.

  • Add remaining pipeline tasks not present in hourly pipeline (security solution, apm)
  • Add missing environmental items only required for PRs, such as git merge base
  • Add docs changes link and CI stats report for PR comments
  • Fail build on bad CI stats report
  • Add annotation for CI stats report
  • Add storybooks preview url to PR comment

See here for an example of a build with failures: https://buildkite.com/elastic/kibana-pull-request/builds/58

@brianseeders brianseeders changed the base branch from buildkite-hourly-ci to master September 13, 2021 21:26
@brianseeders brianseeders self-assigned this Sep 14, 2021
@brianseeders brianseeders changed the title [Buildkite] WIP Pull Request pipeline [Buildkite] Pull Request pipeline Oct 1, 2021
@brianseeders brianseeders added Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.3 v7.15.1 v7.16.0 v8.0.0 labels Oct 1, 2021
@brianseeders brianseeders marked this pull request as ready for review October 1, 2021 20:20
@brianseeders brianseeders requested a review from a team as a code owner October 1, 2021 20:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the uptime Playwright changes were just merged, but that could come as a follow-up since we're not fully switching over with this PR.

https://github.com/elastic/kibana/blob/master/vars/tasks.groovy#L158-L164


cd "$XPACK_DIR"

checks-reporter-with-killswitch "APM Cypress Tests" \
Copy link
Member

@jbudz jbudz Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe depends on #113664?

edit: nevermind, found the thread above. Leaving the note here in case there's a timing issue when this gets merged

@brianseeders brianseeders added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 1, 2021
@brianseeders brianseeders enabled auto-merge (squash) October 1, 2021 22:43
@brianseeders brianseeders merged commit f86e78f into elastic:master Oct 1, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💔 Build #67 failed a0583ce
  • 💚 Build #63 succeeded 07114054e0739c4731ca932f80d1c92363c51328
  • 💚 Build #62 succeeded bad6e87e742ee46a67a60633981e8877553b4d66
  • 💚 Build #61 succeeded 1cb7cf016b9c9aebee56dc31c7d665594ad3c5f2
  • 💚 Build #60 succeeded 8ad63593afa169345e831ab3493374fc822b69cc
  • 💔 Build #58 failed ed35bb0f1078b7f09a458e4ad35f5e24765bd51f

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @brianseeders

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 1, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 1, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 1, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x
7.15
7.14

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 1, 2021
kibanamachine added a commit that referenced this pull request Oct 1, 2021
kibanamachine added a commit that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed buildkite-ci Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.3 v7.15.1 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants