-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Buildkite] Pull Request pipeline #112029
Conversation
fd6704c
to
9c8d289
Compare
Pinging @elastic/kibana-operations (Team:Operations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - the uptime Playwright changes were just merged, but that could come as a follow-up since we're not fully switching over with this PR.
https://github.com/elastic/kibana/blob/master/vars/tasks.groovy#L158-L164
|
||
cd "$XPACK_DIR" | ||
|
||
checks-reporter-with-killswitch "APM Cypress Tests" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe depends on #113664?
edit: nevermind, found the thread above. Leaving the note here in case there's a timing issue when this gets merged
💚 Build Succeeded
History
Metrics [docs]
To update your PR or re-run it, just comment with: |
Co-authored-by: Brian Seeders <[email protected]>
Co-authored-by: Brian Seeders <[email protected]>
Co-authored-by: Brian Seeders <[email protected]>
[skip-ci]
Implement the remaining items to enable pull request pipelines in Buildkite. A lot of work was done elsewhere, e.g. in https://github.com/elastic/kibana-buildkite-build-bot for PR comments.
This PR does not enable PR comments for all PRs or disable PRs in Jenkins. However, it does allow PRs to opt-in to Buildkite PRs (like this one!) by:
[skip-ci]
to the description, to make Jenkins not run CIbuildkite-ci
labelAt that point, the PR will function as normal, except that it will run in Buildkite.
See here for an example of a build with failures: https://buildkite.com/elastic/kibana-pull-request/builds/58