-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] XY. Step 1. Remove all specific logic, related to aggType. #111876
[Canvas] XY. Step 1. Remove all specific logic, related to aggType. #111876
Conversation
# Conflicts: # src/plugins/vis_types/xy/public/vis_component.tsx
Pinging @elastic/kibana-presentation (Team:Presentation) |
@elasticmachine merge upstream |
# Conflicts: # src/plugins/vis_types/xy/kibana.json # src/plugins/vis_types/xy/public/index.ts # src/plugins/vis_types/xy/public/utils/accessors.tsx
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM. Tested various edge cases on bar charts for ranges with complex formatters.
@stratoula and @markov00, could you, please, review the current PR ) thanks for your efforts. |
@nickofthyme, thanks for your review) |
@elasticmachine merge upstream |
208d35f
to
7714247
Compare
# Conflicts: # src/plugins/vis_types/xy/public/services.ts # src/plugins/vis_types/xy/public/utils/accessors.tsx # src/plugins/vis_types/xy/public/vis_component.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, I tested various aggs and combinations and it seems to work fine. I just left two questions :)
As Nick has already approved I think we are fine but if anyone else would like to play it - especially with the bwc - feel free to also test it my dear @elastic/kibana-vis-editors team
const tickFormatter = | ||
aggType === BUCKET_TYPES.DATE_RANGE || aggType === BUCKET_TYPES.RANGE ? identity : formatter; | ||
|
||
const tickFormatter = (v: any) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking here. Can we omit using any
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done)
@@ -278,7 +297,9 @@ export const visTypeXyVisFn = (): VisTypeXyExpressionFunctionDefinition => ({ | |||
splitRow: args.splitRowDimension, | |||
splitColumn: args.splitColumnDimension, | |||
}, | |||
} as VisParams; | |||
// ------------------------------------------------------------------------------------------------------------------ | |||
} as VisParams; /* @TODO: rewrite this `as VisParams` to real `VisParams` via changing accessor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these TODOs are going to be handled in the next steps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as for real, I can remove those Todos , because I've completed mostly all of them )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
8b9b92a
to
884bc38
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: cc @Kunzetsov |
Completes part of #110430 and #101377
Step 1.
XY. Remove all specific logic, related to aggType
completed.