Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX App] Add ux app no data screen #111866

Merged
merged 5 commits into from
Sep 14, 2021
Merged

[UX App] Add ux app no data screen #111866

merged 5 commits into from
Sep 14, 2021

Conversation

shahzad31
Copy link
Contributor

Summary

Fix #111839

Add User Experience app no data screen inline with PR #107709

image

@shahzad31 shahzad31 marked this pull request as ready for review September 10, 2021 14:11
@shahzad31 shahzad31 requested a review from a team as a code owner September 10, 2021 14:11
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Sep 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 mentioned this pull request Sep 10, 2021
Merged
20 tasks
@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 13, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

justinkambic
justinkambic approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, smoke tested with empty local cluster, saw the prompt as I'd expect. Tested against Edge and saw data as I'd expect.

x-pack/plugins/apm/public/components/app/RumDashboard/hooks/useHasRumData.ts Outdated Show resolved Hide resolved
@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 14, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1627 1628 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.4MB 4.4MB +785.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit b610f6f into elastic:master Sep 14, 2021
@shahzad31 shahzad31 deleted the ux-no-data-screen branch September 14, 2021 18:56
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 14, 2021
@shahzad31 @kibanamachine
[UX App] Add ux app no data screen (elastic#111866)
d78d295 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Sep 14, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 14, 2021
@kibanamachine @shahzad31
[UX App] Add ux app no data screen (#111866) (#112162)
6266b9d 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith left review comments

@justinkambic justinkambic justinkambic approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[User Experience App] Implement “no data” check to drive the “no data screens” for User Experience App
5 participants
@shahzad31 @elasticmachine @kibanamachine @smith @justinkambic