Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution][Detections] Enables Index Action and Connector for Detection Actions #111813

Merged
merged 4 commits into from
Oct 19, 2021
Merged

[SecuritySolution][Detections] Enables Index Action and Connector for Detection Actions #111813

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8cf4cd
Adds index action
spong Sep 9, 2021
3082179
Merge branch 'master' into add-index-action
spong Oct 18, 2021
671c032
Merge branch 'master' into add-index-action
kibanamachine Oct 18, 2021
73c3e7e
Merge branch 'master' into add-index-action
kibanamachine Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions x-pack/plugins/security_solution/common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,15 +296,16 @@ export const ML_GROUP_IDS = [ML_GROUP_ID, LEGACY_ML_GROUP_ID];
*/
export const NOTIFICATION_SUPPORTED_ACTION_TYPES_IDS = [
'.email',
'.slack',
'.index',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetized these to better grok -- .index is only new addition.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be careful as this is an array you're alphabetizing. I don't think it will cause problems but I'm just pointing out that typically you don't want to alphabetize arrays if order maters. We have had bugs in the past around people alphabetizing arrays.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point -- thanks for raising! Looks like they're sorted downstream so shouldn't have any side-effects. 👍

This is the order in the UI on master right now:

Order in the UI on this branch:

'.jira',
'.pagerduty',
'.swimlane',
'.webhook',
'.resilient',
'.servicenow',
'.servicenow-sir',
'.jira',
'.resilient',
'.slack',
'.swimlane',
'.teams',
'.webhook',
];

if (ENABLE_CASE_CONNECTOR) {
Expand Down