Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Fixes Error 500 on the workpad update. #111683

Merged
merged 8 commits into from
Sep 16, 2021
Merged

[Canvas] Fixes Error 500 on the workpad update. #111683

merged 8 commits into from
Sep 16, 2021

Conversation

Kuznietsov
Copy link
Contributor

Closes: #111682.

The value of some arguments can be null, and walkAst function was treating it as an argument of type expression. This behavior was fixed at current PR.

@Kuznietsov Kuznietsov added release_note:fix loe:small Small Level of Effort v8.0.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 9, 2021
@Kuznietsov Kuznietsov requested a review from ppisljar September 9, 2021 08:16
@Kuznietsov Kuznietsov self-assigned this Sep 9, 2021
@Kuznietsov Kuznietsov requested a review from a team as a code owner September 9, 2021 08:16
@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Sep 9, 2021
@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov Kuznietsov added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Sep 10, 2021
@Kuznietsov
Copy link
Contributor Author

@elastic/kibana-app-services, could you, please, overview this PR. Thanks a lot)

@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov
Copy link
Contributor Author

@elastic/kibana-app-services, could you, please, overview this PR. Thanks a lot)

@Kuznietsov Kuznietsov removed the request for review from ppisljar September 14, 2021 06:21
@Kuznietsov
Copy link
Contributor Author

@elastic/kibana-app-services, could you, please, overview this PR. Thanks a lot)

@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov
Copy link
Contributor Author

@elastic/kibana-app-services, could you, please, overview this PR. Thanks a lot)

ppisljar
ppisljar approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test for it as well. LGTM

@Kuznietsov
Copy link
Contributor Author

@elasticmachine merge upstream

@Kuznietsov Kuznietsov enabled auto-merge (squash) September 16, 2021 09:34
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressions 219.3KB 219.3KB +5.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

@Kuznietsov Kuznietsov merged commit dbcc75b into elastic:master Sep 16, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 16, 2021
@Kuznietsov @kibanamachine
[Canvas] Fixes Error 500 on the workpad update. (elastic#111683)
de6b877 
* Fixed bug with treating null argument as the expression function.

* Added a test for checking if a null argument is processeded correctly.

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Sep 16, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 16, 2021
@kibanamachine @Kuznietsov
[Canvas] Fixes Error 500 on the workpad update. (#111683) (#112399)
7f4585f 
* Fixed bug with treating null argument as the expression function.

* Added a test for checking if a null argument is processeded correctly.

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Yaroslav Kuznietsov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees

@Kuznietsov Kuznietsov

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort release_note:fix v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Canvas] Error 500 on the workpad update.
3 participants
@Kuznietsov @kibanamachine @ppisljar