Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated xpack.security.enabled config option #111681

Merged
merged 7 commits into from
Oct 25, 2021

Conversation

watson
Copy link
Contributor

@watson watson commented Sep 9, 2021

Depends on #111706

This config option is already deprecated in 7.x.

To enable or disable the security plugin, set this option in Elasticsearch instead.

Closes #54023

Release note

Removes the deprecated "xpack.security.enabled" config option. This should instead be controlled via the similarly named config option in elasticsearch.yml.

@watson watson added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Sep 9, 2021
@watson watson self-assigned this Sep 9, 2021
@watson watson removed the release_note:skip Skip the PR/issue when compiling release notes label Sep 9, 2021
@watson watson changed the title Remove xpack.security.enabled config option from Kibana Remove deprecated xpack.security.enabled config option Sep 9, 2021
@watson watson force-pushed the config-security-enabled branch from 8d9d046 to c9ec68a Compare September 9, 2021 10:55
@jportner
Copy link
Contributor

jportner commented Sep 9, 2021

@elastic/kibana-core Thomas started this PR to address #54023

However, there is overlap with your larger issue #89584. To quote that issue:

Toward the end of the 7.16 dev cycle, we will open a PR removing enabled from any plugins that don't have a yes indicated below. To prepare for this update, we'd ask that folks review the affected plugins by 31 August 2021.

The Security plugin currently has an explicit config option for enabled. Should we be removing it in this PR, or would you prefer to tackle it as part of your larger issue?

@lukeelmers
Copy link
Member

The Security plugin currently has an explicit config option for enabled. Should we be removing it in this PR, or would you prefer to tackle it as part of your larger issue?

Feel free to remove it in this PR -- currently I am readying a PR to add deprecations to all affected plugins which don't have one yet, but our PR to do the actual removal of the old configs won't come until a follow-up PR. So if this PR merges in the interim, that should be fine.

@watson watson force-pushed the config-security-enabled branch 2 times, most recently from ee269cc to ccee01f Compare October 20, 2021 20:36
@elastic elastic deleted a comment from kibanamachine Oct 21, 2021
@watson watson force-pushed the config-security-enabled branch 2 times, most recently from 8614e8b to a287ed9 Compare October 21, 2021 17:31
To enable or disable the security plugin, set this option in
Elasticsearch instead.
The 21 new integrations are all enterprise_search integrations which
wasn't included before because the security plugin was disabled (a
dependency of enterprise_search).
@watson watson force-pushed the config-security-enabled branch from a287ed9 to e8ace45 Compare October 21, 2021 18:13
@watson watson marked this pull request as ready for review October 21, 2021 18:14
@watson watson requested review from a team as code owners October 21, 2021 18:14
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is the only Fleet-related change in question. Approving for Fleet codeowner review 🚀

Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporting changes LGTM

@legrego legrego merged commit f152787 into elastic:master Oct 25, 2021
@watson watson deleted the config-security-enabled branch October 26, 2021 08:09
jportner pushed a commit to jportner/kibana that referenced this pull request Apr 11, 2022
This is a partial backport of elastic#111681, so the Kibana security
plugin is enabled but Elasticsearch security is still disabled.
jportner added a commit that referenced this pull request Apr 11, 2022
…#129857)

* Test config settings that are exposed to the browser (#129438)

(cherry picked from commit 27ff7d3)

# Conflicts:
#	.github/CODEOWNERS
#	packages/kbn-config-schema/src/index.ts

* Enable security plugin in OSS tests

This is a partial backport of #111681, so the Kibana security
plugin is enabled but Elasticsearch security is still disabled.

* Fix exposed config key tests

The exposed config keys are slightly different in the 7.17 branch.

* Fix UI Capabilities tests

The enterpriseSearch plugin does not have a required dependency on
the security plugin in the 7.17 branch, so our bacported
assertions for these tests needed to change accordingly.
robb3rt pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards
dedemorton pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards
mergify bot pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)
mergify bot pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)
mergify bot pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)
mergify bot pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)
mergify bot pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)
mergify bot pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)
dedemorton pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)

Co-authored-by: Robbert Hink <[email protected]>
dedemorton pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)

Co-authored-by: Robbert Hink <[email protected]>
dedemorton pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)

Co-authored-by: Robbert Hink <[email protected]>
dedemorton pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)

Co-authored-by: Robbert Hink <[email protected]>
dedemorton pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)

Co-authored-by: Robbert Hink <[email protected]>
dedemorton pushed a commit to elastic/observability-docs that referenced this pull request Nov 3, 2022
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards

(cherry picked from commit fe73e13)

Co-authored-by: Robbert Hink <[email protected]>
bmorelli25 pushed a commit to bmorelli25/ingest-docs that referenced this pull request Dec 19, 2022
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
The setting `xpack.security.enabled` [has been removed since 8.0.0](elastic/kibana#111681) so following these instructions will result in errors from the Kibana side. This file needs to be adjusted for versions of 8.0.0 and upwards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:breaking Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore xpack.security.enabled setting