Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reporting/use defaults fn tests server config 7.15 #111677

Closed
wants to merge 8 commits into from
Closed

Reporting/use defaults fn tests server config 7.15 #111677

wants to merge 8 commits into from

Conversation

tsullivan
Copy link
Member

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@tsullivan
[Reporting] use default settings in test server config
6d5d2b6
@tsullivan
fix discover csv tests
4a7c0e6
@tsullivan
allow reporting tests to pass in cloud
d5b7aa4
@tsullivan
update snapshots
8aadfd2
@tsullivan
Squashed commit of the following:
f959319 
commit ef2a4085f1b8eb25dd32d13428d7d5de9c1148cc
Author: Timothy Sullivan <[email protected]>
Date:   Thu Sep 9 11:57:50 2021 -0700

    update snapshot

commit 750b55fbfad1621d58d6bb3534696fba4977a4c2
Author: Timothy Sullivan <[email protected]>
Date:   Thu Sep 9 10:00:05 2021 -0700

    update snapshots

commit 4d133f28a1a81f090281f61d03c084e97c1c69a3
Author: Timothy Sullivan <[email protected]>
Date:   Wed Sep 8 23:57:48 2021 -0700

    allow reporting tests to pass in cloud

commit 7dead38811bf50f12f028713e2c95be5a90f6962
Author: Timothy Sullivan <[email protected]>
Date:   Wed Sep 8 23:39:37 2021 -0700

    fix discover csv tests

commit 030cefe5457458b14af0bbf24adf4a85fcbb472c
Author: Timothy Sullivan <[email protected]>
Date:   Wed Sep 8 23:03:38 2021 -0700

    [Reporting] use default settings in test server config

commit fd6c1d1
Author: Kibana Machine <[email protected]>
Date:   Thu Sep 9 14:28:05 2021 -0400

    Use correct z-index for timeline global footer (elastic#111492) (elastic#111749)

    Co-authored-by: Kevin Qualters <[email protected]>

commit 506b09b
Author: Kibana Machine <[email protected]>
Date:   Thu Sep 9 14:17:55 2021 -0400

    [ML] Functional tests - skip color assertions in cloud (elastic#111695) (elastic#111751)

    This PR skips color assertions during functional tests in cloud environments.

    Co-authored-by: Robert Oskamp <[email protected]>

commit e767408
Author: Kaarina Tungseth <[email protected]>
Date:   Thu Sep 9 11:53:57 2021 -0500

    [DOCS] Adds preview to runtime fields (elastic#110327) (elastic#111765)

    * [DOCS] Adds preview to runtime fields

    * Final draft changes

    * Review comments

commit 99533b6
Author: Lisa Cawley <[email protected]>
Date:   Thu Sep 9 08:41:39 2021 -0700

    [7.15][DOCS] APM failed transaction correlations elastic#111219 (elastic#111666)

commit f1dc752
Author: Kibana Machine <[email protected]>
Date:   Thu Sep 9 11:36:24 2021 -0400

    [Metrics UI] Remove rounding from Metric Threshold start time (elastic#111634) (elastic#111727)

    * [Metrics UI] Remove rounding from Metric Threshold start time

    * adding missed files

    Co-authored-by: Chris Cowan <[email protected]>

commit 99789fe
Author: Kibana Machine <[email protected]>
Date:   Thu Sep 9 11:02:54 2021 -0400

    [Fleet] Fix config migration from ingestManager to support both xpack.fleet and xpack.ingestManager config values (elastic#111612) (elastic#111714)

    Co-authored-by: Nicolas Chaulet <[email protected]>

commit d82c54f
Author: Kibana Machine <[email protected]>
Date:   Thu Sep 9 10:12:32 2021 -0400

    [Security Solution] add timeline id to context (elastic#111435) (elastic#111711)

    * add timeline context

    * remove an unused file

    Co-authored-by: Angela Chuang <[email protected]>

commit e584d54
Author: Kibana Machine <[email protected]>
Date:   Thu Sep 9 06:56:48 2021 -0400

    Fix focus jumps from Case description box back to Alerts table with first <return> keystroke (elastic#111273) (elastic#111691)

    Co-authored-by: Kibana Machine <[email protected]>

    Co-authored-by: Pablo Machado <[email protected]>
@tsullivan
Merge branch '7.15' into reporting/use-defaults-fn-tests-server-confi…
7db1305 
…g-7.15
@tsullivan
update snapshot
488cfc9
@tsullivan
update snapshots
e1dc69d
@elastic elastic deleted a comment from kibanamachine Sep 9, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

Replaced with #111824

@tsullivan tsullivan closed this Sep 10, 2021
@tsullivan tsullivan deleted the reporting/use-defaults-fn-tests-server-config-7.15 branch September 10, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsullivan @kibanamachine