Discover and visualization set appStatus.dirty before saving new #11156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharing relies upon appStatus.dirty to determine whether changes have been made that must be saved. This wasn't being set correctly in Discover and Visualize when the user first creates a new object and hasn't saved it yet.
kobelb
added
:Discovery
Feature:Visualizations
|
@kobelb Does this affect 5.4? If so, we should get it in there as well. We can still fix bugs there. |
|
It's not a user-impacting bug at the moment, as the existing sharing functionality is also parsing the url to determine whether it's been saved or not and isn't solely relying upon isDirty. |
thomasneirynck
approved these changes
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing relies upon appStatus.dirty to determine whether changes have been made that must be saved. This wasn't being set correctly in Discover and Visualize when the user first creates a new object and hasn't saved it yet.