Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Vislib] Removes old implementation of xy chart (#110786) #111558

Merged
merged 4 commits into from
Sep 8, 2021

Conversation

stratoula
Copy link
Contributor

Backports the following commits to 7.x:

* [Vislib] Remove xy chart

* Update i18n

* Remove uncecessary file

* Fix types

* More fixes

* Fix functional tests part 1

* Fix functional tests part 2

* Fix bug with shard-delay

* Fix functional tests part 3

* fix functional tests part4

* Fix async_serch FT

* Fix functional dashboard async test

* REplace screenshot area chart image

* Cleanup vislib from xy charts

* Remove unused fixtures

* Address PR comments

* Remove miaou :D

* Address PR comments

* Fix i18n

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	docs/management/advanced-options.asciidoc
#	test/functional/screenshots/baseline/area_chart.png
@stratoula stratoula enabled auto-merge (squash) September 8, 2021 15:40
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeVislib 207 199 -8
visualize 83 82 -1
total -9

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
visTypeXy 63 51 -12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimelion 137.7KB 137.7KB -1.0B
visTypeVislib 564.9KB 548.3KB -16.5KB
visTypeXy 115.3KB 114.1KB -1.2KB
visualize 89.0KB 87.0KB -2.1KB
total -19.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
visTypeXy 6 5 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeVislib 32.9KB 31.9KB -1.0KB
visTypeXy 63.5KB 62.3KB -1.2KB
total -2.3KB
Unknown metric groups

API count

id before after diff
visTypeXy 69 57 -12

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 705d2b0 into elastic:7.x Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants