Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CTI] Remove fullWidth for enrichment range picker #111502

Merged
merged 2 commits into from
Sep 13, 2021
Merged

[CTI] Remove fullWidth for enrichment range picker #111502

merged 2 commits into from
Sep 13, 2021

Conversation

nkhristinin
Copy link
Contributor

Remove fullWidth for enrichment range picker.

Because in the EUI library the max-width for the range picker is 400px by default, for this PR it's enough to just remove fullWidth props, and not customise component width in our project.

Screenshot 2021-09-08 at 10 52 08

@nkhristinin nkhristinin requested a review from a team as a code owner September 8, 2021 09:04
@nkhristinin nkhristinin changed the title Remove fullWidth for enrichment range picker [CTI] Remove fullWidth for enrichment range picker Sep 8, 2021
@nkhristinin nkhristinin added v7.16.0 v8.0.0 Team: CTI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Sep 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@nkhristinin nkhristinin added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Sep 8, 2021
@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB -8.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ecezalp
ecezalp approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@ecezalp ecezalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Screen Shot 2021-09-13 at 10 47 02 AM

@nkhristinin nkhristinin merged commit ef65bcb into elastic:master Sep 13, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 13, 2021
@nkhristinin @kibanamachine
Remove fullWidth for enrichment range picekr (elastic#111502)
cec95b7 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Sep 13, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 13, 2021
@kibanamachine @nkhristinin
Remove fullWidth for enrichment range picekr (#111502) (#111964)
723395c 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Khristinin Nikita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecezalp ecezalp ecezalp approved these changes

@yiyangliu9286 yiyangliu9286 Awaiting requested review from yiyangliu9286

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team: CTI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nkhristinin @elasticmachine @kibanamachine @ecezalp