-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App Search] Show process crawls together with crawl requests #111398
[App Search] Show process crawls together with crawl requests #111398
Conversation
onReceiveCrawlerData: (_, { data: { events } }) => events, | ||
}, | ||
], | ||
mostRecentCrawlRequest: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems weird to me that we get the mostRecentCrawl request from the API rather than grabbing it from the list of all events ourselves. Is there a circumstance in which the value returned by the API for mostRecentCrawlRequest
would not be the first non-skipped crawl request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new API in use here returns events, which is a combined list of process crawls and crawl requests. So the list of events could potentially only consist of process crawls, meaning we can no longer compute the most recent crawl request.
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Co-authored-by: Orhan Toy <[email protected]>
Summary
We want to show the user that a process crawl is being run in the background and the status of it. We already do that for crawl requests, which represent regular crawls.