Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Search] Show process crawls together with crawl requests #111398

Merged
merged 3 commits into from
Sep 14, 2021
Merged

[App Search] Show process crawls together with crawl requests #111398

merged 3 commits into from
Sep 14, 2021

Conversation

orhantoy
Copy link
Contributor

@orhantoy orhantoy commented Sep 7, 2021

Summary

We want to show the user that a process crawl is being run in the background and the status of it. We already do that for crawl requests, which represent regular crawls.

Screen Shot 2021-09-07 at 16 22 04

@orhantoy orhantoy added Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 7, 2021
@orhantoy orhantoy marked this pull request as ready for review September 9, 2021 20:26
@orhantoy orhantoy requested review from a team and byronhulcher September 9, 2021 20:26
onReceiveCrawlerData: (_, { data: { events } }) => events,
},
],
mostRecentCrawlRequest: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems weird to me that we get the mostRecentCrawl request from the API rather than grabbing it from the list of all events ourselves. Is there a circumstance in which the value returned by the API for mostRecentCrawlRequest would not be the first non-skipped crawl request?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new API in use here returns events, which is a combined list of process crawls and crawl requests. So the list of events could potentially only consist of process crawls, meaning we can no longer compute the most recent crawl request.

@byronhulcher
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.1MB +28.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@orhantoy orhantoy merged commit a55c39b into elastic:master Sep 14, 2021
@orhantoy orhantoy deleted the list-process-crawls-together-with-crawl-requests branch September 14, 2021 10:59
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 14, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants