Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy data table #111339

Merged
merged 9 commits into from
Sep 14, 2021
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion scripts/functional_tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ const alwaysImportedTests = [
require.resolve('../test/ui_capabilities/newsfeed_err/config.ts'),
require.resolve('../test/new_visualize_flow/config.ts'),
require.resolve('../test/security_functional/config.ts'),
require.resolve('../test/functional/config.legacy.ts'),
Copy link
Contributor Author

@stratoula stratoula Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ This functional test suite runs the tests for the legacy implementation (angular). The same tests run for the new implementation so we don't lose our test coverage here!

];
// eslint-disable-next-line no-restricted-syntax
const onlyNotInCoverageTests = [
Expand Down
7 changes: 1 addition & 6 deletions src/plugins/vis_type_table/README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
Contains the data table visualization, that allows presenting data in a simple table format.

By default a new version of visualization will be used. To use the previous version of visualization the config must have the `vis_type_table.legacyVisEnabled: true` setting
configured in `kibana.dev.yml` or `kibana.yml`, as shown in the example below:

```yaml
vis_type_table.legacyVisEnabled: true
```
Aggregation-based datatable visualizations uses EuiDataGrid component.
5 changes: 1 addition & 4 deletions src/plugins/vis_type_table/common/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,4 @@
* Side Public License, v 1.
*/

// TODO: https://github.com/elastic/kibana/issues/110891
/* eslint-disable @kbn/eslint/no_export_all */

export * from './types';
export { AggTypes, TableVisParams, VIS_TYPE_TABLE } from './types';
1 change: 0 additions & 1 deletion src/plugins/vis_type_table/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { schema, TypeOf } from '@kbn/config-schema';

export const configSchema = schema.object({
enabled: schema.boolean({ defaultValue: true }),
legacyVisEnabled: schema.boolean({ defaultValue: false }),
});

export type ConfigSchema = TypeOf<typeof configSchema>;
2 changes: 1 addition & 1 deletion src/plugins/vis_type_table/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@
"name": "Vis Editors",
"githubTeam": "kibana-vis-editors"
},
"description": "Registers the datatable aggregation-based visualization. Currently it contains two implementations, the one based on EUI datagrid and the angular one. The second one is going to be removed in future minors."
"description": "Registers the datatable aggregation-based visualization."
}
5 changes: 2 additions & 3 deletions src/plugins/vis_type_table/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@
* Side Public License, v 1.
*/

import { PluginInitializerContext } from 'kibana/public';
import { TableVisPlugin as Plugin } from './plugin';

export function plugin(initializerContext: PluginInitializerContext) {
return new Plugin(initializerContext);
export function plugin() {
return new Plugin();
}

This file was deleted.

25 changes: 0 additions & 25 deletions src/plugins/vis_type_table/public/legacy/_table_vis.scss

This file was deleted.

42 changes: 0 additions & 42 deletions src/plugins/vis_type_table/public/legacy/agg_table/_agg_table.scss

This file was deleted.

This file was deleted.

34 changes: 0 additions & 34 deletions src/plugins/vis_type_table/public/legacy/agg_table/agg_table.html

This file was deleted.

Loading