Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Remove any, improve telemetry schema for completeness #111212

Merged
merged 12 commits into from
Sep 8, 2021
Merged

[Reporting] Remove any, improve telemetry schema for completeness #111212

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b0d5566
[Reporting] Remove `any`, improve telemetry schema for completeness
tsullivan Sep 3, 2021
bfb4056
remove another any
tsullivan Sep 3, 2021
4fea726
rename file per exported function
tsullivan Sep 3, 2021
6f178a1
test variable name
tsullivan Sep 3, 2021
771a191
use variable for DRY
tsullivan Sep 3, 2021
06b021d
update reporting telemetry contract
tsullivan Sep 3, 2021
4d6b6a9
added csv_searchsource_immediate to telemetry
jloleysens Sep 6, 2021
17bad33
Merge branch 'master' into reporting/fix-telemetry-types
kibanamachine Sep 6, 2021
663e413
fix types
jloleysens Sep 7, 2021
206678c
update jest snapshots
jloleysens Sep 7, 2021
69a45f0
remove tests on large literal objects
tsullivan Sep 7, 2021
6642010
Merge branch 'master' into reporting/fix-telemetry-types
kibanamachine Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/reporting/server/export_types/csv_searchsource/generate_csv/generate_csv.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ export class CsvGenerator {
data: dataTableCell,
}: {
column: string;
data: any;
data: unknown;
}): string => {
let cell: string[] | string | object;
// check truthiness to guard against _score, _type, etc
Expand Down
Loading