Functional tests for execution context propagation in alerting and task manager plugins #111179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
chore
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
mshustov
commented
Sep 6, 2021
| }, | ||
| }); | ||
|
|
||
| alerting.registerType({ |
There was a problem hiding this comment.
The plugin registers a custom alert. Test suit will create an instance of this alert.
mshustov
commented
Sep 6, 2021
|
|
||
| export default function ({ loadTestFile }: FtrProviderContext) { | ||
| describe('Execution context', function () { | ||
| this.tags('ciGroup1'); |
There was a problem hiding this comment.
I separated tests to avoid skipping both in case of flakiness
mshustov
commented
Sep 6, 2021
| .send({ | ||
| enabled: true, | ||
| name: 'abc', | ||
| tags: ['foo'], |
There was a problem hiding this comment.
pgayvallet
approved these changes
Sep 7, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Sep 14, 2021
…sk manager plugins (elastic#111179) * move execution context tests to x-pack folder * add execution context tests for alerts and tasks * cleanup tests * remove obsolete test folder * use ToolingLog instead of console.log # Conflicts: # scripts/functional_tests.js # x-pack/scripts/functional_tests.js
mshustov
added a commit
that referenced
this pull request
Sep 14, 2021
…sk manager plugins (#111179) (#112066) * move execution context tests to x-pack folder * add execution context tests for alerts and tasks * cleanup tests * remove obsolete test folder * use ToolingLog instead of console.log # Conflicts: # scripts/functional_tests.js # x-pack/scripts/functional_tests.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Functionals tests for Alerts and Task manager to propagate execution context data.