-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused legacy import code #111071
Merged
TinaHeiligers
merged 25 commits into
elastic:master
from
TinaHeiligers:tech-debt/remove_unused_lib_legacy_code
Sep 7, 2021
Merged
Remove unused legacy import code #111071
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
95316f7
Removes support for legacy exports
TinaHeiligers c98a48f
Removes code that hooks into legacy imports
TinaHeiligers 48076d7
Updates flyout component unit tests
TinaHeiligers b6f34d8
Removes commented out code from import_mode_control
TinaHeiligers b14dd50
Fix types, fix i18n
TinaHeiligers a284dd6
removes another unused const
TinaHeiligers 8f5261a
Updates test but should remove it because it tests legacy imports
TinaHeiligers b7e7a18
deletes dashboard bwc_import test and fixture, deletes legacy timezon…
TinaHeiligers b2d990b
Deletes timezone test as that used to test against legacy imports
TinaHeiligers ffa9bfc
Updates mgmt import objects fixture to normal format
TinaHeiligers 1f61d9e
Merge branch 'master' into so-management/remove_legacy_import_support
kibanamachine c0299e6
Restores dashboard functional tests and skips them for the presentati…
TinaHeiligers 912c588
Deletes unused json exports
TinaHeiligers 7fac104
Merge branch 'master' of github.com:elastic/kibana into so-management…
TinaHeiligers 317a448
Removes duplicate code, moves component contents inline
TinaHeiligers bb515a6
Adds comments to methods/types no longer used after legacy import sup…
TinaHeiligers 4071c98
Removes unused methods in lib, updates flyout test
TinaHeiligers 7f53830
Completes first pass at removing unused code from legacy format saved…
TinaHeiligers 31662ca
i18n fix
TinaHeiligers e2dd061
Updates types
TinaHeiligers 91f992a
deletes code comment
TinaHeiligers 9e9bceb
Merge branch 'master' into tech-debt/remove_unused_lib_legacy_code
TinaHeiligers 81120e6
Merge branch 'master' into tech-debt/remove_unused_lib_legacy_code
kibanamachine 5861c03
Removes conflictedSearchDocs from flyout
TinaHeiligers 2255c5a
Merge branch 'master' into tech-debt/remove_unused_lib_legacy_code
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 0 additions & 50 deletions
50
src/core/server/saved_objects/routes/integration_tests/log_legacy_import.test.ts
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
26 changes: 0 additions & 26 deletions
26
src/plugins/saved_objects_management/public/lib/import_legacy_file.test.ts
This file was deleted.
Oops, something went wrong.
22 changes: 0 additions & 22 deletions
22
src/plugins/saved_objects_management/public/lib/import_legacy_file.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 0 additions & 13 deletions
13
src/plugins/saved_objects_management/public/lib/log_legacy_import.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goodbye
resolveSavedObjects
, you won't be missed.