Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused legacy import code #111071

Merged
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
95316f7
Removes support for legacy exports
TinaHeiligers Aug 31, 2021
c98a48f
Removes code that hooks into legacy imports
TinaHeiligers Aug 31, 2021
48076d7
Updates flyout component unit tests
TinaHeiligers Aug 31, 2021
b6f34d8
Removes commented out code from import_mode_control
TinaHeiligers Sep 1, 2021
b14dd50
Fix types, fix i18n
TinaHeiligers Sep 1, 2021
a284dd6
removes another unused const
TinaHeiligers Sep 1, 2021
8f5261a
Updates test but should remove it because it tests legacy imports
TinaHeiligers Sep 1, 2021
b7e7a18
deletes dashboard bwc_import test and fixture, deletes legacy timezon…
TinaHeiligers Sep 1, 2021
b2d990b
Deletes timezone test as that used to test against legacy imports
TinaHeiligers Sep 1, 2021
ffa9bfc
Updates mgmt import objects fixture to normal format
TinaHeiligers Sep 1, 2021
1f61d9e
Merge branch 'master' into so-management/remove_legacy_import_support
kibanamachine Sep 1, 2021
c0299e6
Restores dashboard functional tests and skips them for the presentati…
TinaHeiligers Sep 2, 2021
912c588
Deletes unused json exports
TinaHeiligers Sep 2, 2021
7fac104
Merge branch 'master' of github.com:elastic/kibana into so-management…
TinaHeiligers Sep 2, 2021
317a448
Removes duplicate code, moves component contents inline
TinaHeiligers Sep 2, 2021
bb515a6
Adds comments to methods/types no longer used after legacy import sup…
TinaHeiligers Sep 2, 2021
4071c98
Removes unused methods in lib, updates flyout test
TinaHeiligers Sep 2, 2021
7f53830
Completes first pass at removing unused code from legacy format saved…
TinaHeiligers Sep 2, 2021
31662ca
i18n fix
TinaHeiligers Sep 3, 2021
e2dd061
Updates types
TinaHeiligers Sep 3, 2021
91f992a
deletes code comment
TinaHeiligers Sep 3, 2021
9e9bceb
Merge branch 'master' into tech-debt/remove_unused_lib_legacy_code
TinaHeiligers Sep 3, 2021
81120e6
Merge branch 'master' into tech-debt/remove_unused_lib_legacy_code
kibanamachine Sep 5, 2021
5861c03
Removes conflictedSearchDocs from flyout
TinaHeiligers Sep 6, 2021
2255c5a
Merge branch 'master' into tech-debt/remove_unused_lib_legacy_code
kibanamachine Sep 6, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/core/server/saved_objects/routes/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import { registerUpdateRoute } from './update';
import { registerBulkGetRoute } from './bulk_get';
import { registerBulkCreateRoute } from './bulk_create';
import { registerBulkUpdateRoute } from './bulk_update';
import { registerLogLegacyImportRoute } from './log_legacy_import';
import { registerExportRoute } from './export';
import { registerImportRoute } from './import';
import { registerResolveImportErrorsRoute } from './resolve_import_errors';
Expand Down Expand Up @@ -50,7 +49,6 @@ export function registerRoutes({
registerBulkGetRoute(router, { coreUsageData });
registerBulkCreateRoute(router, { coreUsageData });
registerBulkUpdateRoute(router, { coreUsageData });
registerLogLegacyImportRoute(router, logger);
registerExportRoute(router, { config, coreUsageData });
registerImportRoute(router, { config, coreUsageData });
registerResolveImportErrorsRoute(router, { config, coreUsageData });
Expand Down

This file was deleted.

23 changes: 0 additions & 23 deletions src/core/server/saved_objects/routes/log_legacy_import.ts

This file was deleted.

This file was deleted.

This file was deleted.

9 changes: 0 additions & 9 deletions src/plugins/saved_objects_management/public/lib/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,8 @@ export { getRelationships } from './get_relationships';
export { getSavedObjectCounts } from './get_saved_object_counts';
export { getSavedObjectLabel } from './get_saved_object_label';
export { importFile } from './import_file';
export { importLegacyFile } from './import_legacy_file';
export { parseQuery } from './parse_query';
export { resolveImportErrors } from './resolve_import_errors';
export {
resolveIndexPatternConflicts,
resolveSavedObjects,
resolveSavedSearches,
Comment on lines -19 to -22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye resolveSavedObjects, you won't be missed.

saveObject,
saveObjects,
} from './resolve_saved_objects';
export { logLegacyImport } from './log_legacy_import';
export {
processImportResponse,
ProcessedImportResponse,
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ export interface ProcessedImportResponse {
unmatchedReferences: UnmatchedReference[];
status: 'success' | 'idle';
importCount: number;
conflictedSavedObjectsLinkedToSavedSearches: undefined;
conflictedSearchDocs: undefined;
importWarnings: SavedObjectsImportWarning[];
}

Expand Down Expand Up @@ -87,8 +85,6 @@ export function processImportResponse(
? 'success'
: 'idle',
importCount: response.successCount,
conflictedSavedObjectsLinkedToSavedSearches: undefined,
conflictedSearchDocs: undefined,
importWarnings: response.warnings,
};
}
Loading