[Task Manager] Support excluding certain task types from executing #111036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
changed the title
chrisronline
changed the title
chrisronline
changed the title
chrisronline
added
Feature:Task Manager
review
Team:ResponseOps
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
chrisronline
added
the
release_note:skip
ymao1
approved these changes
Sep 7, 2021
ymao1
approved these changes
Sep 8, 2021
Co-authored-by: Mike Côté <[email protected]>
pgayvallet
approved these changes
Sep 9, 2021
|
@elasticmachine merge upstream |
chrisronline
force-pushed
the
task_manager/exclude_task_types
branch
from
8da2603 to
587f6a2
Compare
gchaps
reviewed
Sep 10, 2021
Co-authored-by: gchaps <[email protected]>
pmuellr
approved these changes
Sep 13, 2021
| } | ||
|
|
||
| if (this.config.unsafe.exclude_task_types.length) { | ||
| this.logger.debug( |
There was a problem hiding this comment.
Since we've labelled this as unsafe/experimental, wondering if we should elevate this message to an info, or perhaps even warning.
There was a problem hiding this comment.
+1 to a warning. It would make it clear what's happening without a way to ignore it.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Sep 13, 2021
…lastic#111036) * Support excluding certain action types * Fix types * Fix jest tests * Flip this * Add functional test * Add to README * Updated README * Add startup log * Update x-pack/plugins/task_manager/README.md Co-authored-by: Mike Côté <[email protected]> * Add telemetry * Add test * Rename internal to unsafe * Update test config * Fix tests * Update x-pack/plugins/task_manager/README.md Co-authored-by: gchaps <[email protected]> * PR feedback Co-authored-by: Mike Côté <[email protected]> Co-authored-by: gchaps <[email protected]>
chrisronline
added a commit
that referenced
this pull request
Sep 13, 2021
…111036) (#112022) * Support excluding certain action types * Fix types * Fix jest tests * Flip this * Add functional test * Add to README * Updated README * Add startup log * Update x-pack/plugins/task_manager/README.md Co-authored-by: Mike Côté <[email protected]> * Add telemetry * Add test * Rename internal to unsafe * Update test config * Fix tests * Update x-pack/plugins/task_manager/README.md Co-authored-by: gchaps <[email protected]> * PR feedback Co-authored-by: Mike Côté <[email protected]> Co-authored-by: gchaps <[email protected]> Co-authored-by: Mike Côté <[email protected]> Co-authored-by: gchaps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #108757
We want to prevent users from disabling the alerting teams plugins (which we did here) but still want to provide an option to disable rules/actions from executing if necessary (usually to isolate some performance issue).
This PR exposes a new, undocumented config to task manager, called
xpack.task_manager.internal.exclude_task_types, that allows users to specify an array of task types that will not execute. This config supports using a wildcard*to do pattern matching on the task type. All task types that match any of the configured patterns will not execute but remain in the queue (they won't ever be claimed by Kibanas configured to exclude them)