Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Graph] Deangularize graph app controller (#106587) #110669

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Aug 31, 2021

Backports the following commits to 7.x:

* [Graph] deaungularize control panel

* [Graph] move main graph directive to react

* [Graph] refactoring

* [Graph] remove redundant memoization, update import

* [Graph] fix settings menu, clean up the code

* [Graph] fix graph settings

* [Graph] code refactoring, fixing control panel render issues

* [Graph] fix small mistake

* [Graph] rename components

* [Graph] fix imports

* [Graph] fix graph search and inspect panel

* [Graph] remove redundant types

* [Graph] fix problem with selection list

* [Graph] fix functional test which uses selection list

* [Graph] fix unit tests, update types

* [Graph] fix types

* [Discover] fix url queries

* [Graph] fix types

* [Graph] add react router, remove angular stuff

* [Graph] fix styles

* [Graph] fix i18n

* [Graph] fix navigation to a new workspace creation

* [Graph] fix issues from comments

* [Graph] add suggested changed

* Update x-pack/plugins/graph/public/components/graph_visualization/graph_visualization.tsx

Co-authored-by: Marco Liberati <[email protected]>

* [Graph] remove brace lib from imports

* [Graph] fix url navigation between workspaces, fix types

* [Graph] refactoring, fixing url issue

* [Graph] update graph dependencies

* [Graph] add comments

* [Graph] fix types

* [Graph] fix new button, fix control panel styles

* [Graph] apply suggestions

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Marco Liberati <[email protected]>
@dimaanj dimaanj enabled auto-merge (squash) August 31, 2021 16:35
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
graph 157 167 +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
graph 1.1MB 656.8KB -500.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
graph 11.5KB 11.1KB -367.0B
Unknown metric groups

References to deprecated APIs

id before after diff
graph 65 97 +32

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dimaanj dimaanj merged commit 73edec9 into elastic:7.x Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants