Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Canvas] Adds references extract/inject for Workpads (#109874) #110621

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Aug 31, 2021

Backports the following commits to 7.x:

* Register embeddable functions server side.  Adds reference extraction/injection to workpads

* Clean up

* Fix Types

* Update API docs

* Remove API doc from expression (bad conflict resolution)

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	src/plugins/embeddable/kibana.json
#	x-pack/plugins/canvas/canvas_plugin_src/functions/external/index.ts
@crob611 crob611 enabled auto-merge (squash) August 31, 2021 13:59
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
embeddable 83 84 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
discover 55 56 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.6MB 1.6MB +13.0B
discover 550.5KB 551.6KB +1.0KB
visualizations 101.5KB 101.5KB +2.0B
total +1.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 28.4KB 28.7KB +257.0B
discover 91.8KB 92.5KB +713.0B
embeddable 160.3KB 163.5KB +3.2KB
visualizations 58.5KB 58.7KB +232.0B
total +4.4KB
Unknown metric groups

API count

id before after diff
discover 81 82 +1

References to deprecated APIs

id before after diff
canvas 64 46 -18

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crob611 crob611 merged commit 3172b55 into elastic:7.x Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants