Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Osquery] Fix support for disabled security #110547

Merged
merged 14 commits into from
Sep 6, 2021
Merged

[Osquery] Fix support for disabled security #110547

merged 14 commits into from
Sep 6, 2021

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Aug 30, 2021 •
edited
Loading

Summary

image (16)

@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Asset Management Security Asset Management Team Feature:Osquery Security Solution Osquery feature auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 labels Aug 30, 2021
@patrykkopycinski patrykkopycinski self-assigned this Aug 30, 2021
@patrykkopycinski patrykkopycinski requested a review from a team as a code owner August 30, 2021 22:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-asset-management (Team:Asset Management)

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

jportner
jportner approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski enabled auto-merge (squash) September 4, 2021 19:57
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
osquery 264 265 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 2.4MB 2.4MB +4.5KB
Unknown metric groups

References to deprecated APIs

id before after diff
osquery 4 22 +18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

@patrykkopycinski patrykkopycinski merged commit 4416a31 into elastic:master Sep 6, 2021
@patrykkopycinski patrykkopycinski deleted the fix/osquery-privileges-check-security-disabled branch September 6, 2021 07:10
@kibanamachine kibanamachine mentioned this pull request Sep 6, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 6, 2021
@patrykkopycinski @kibanamachine
[Osquery] Fix support for disabled security (elastic#110547)
7bde921
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 6, 2021
@patrykkopycinski @kibanamachine
[Osquery] Fix support for disabled security (elastic#110547)
d54766b
@kibanamachine kibanamachine mentioned this pull request Sep 6, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 6, 2021
@kibanamachine @patrykkopycinski
[Osquery] Fix support for disabled security (#110547) (#111250)
effc87b 
Co-authored-by: Patryk Kopyciński <[email protected]>
kibanamachine added a commit that referenced this pull request Sep 6, 2021
@kibanamachine @patrykkopycinski
[Osquery] Fix support for disabled security (#110547) (#111249)
dcbd924 
Co-authored-by: Patryk Kopyciński <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-elastic james-elastic james-elastic approved these changes

@jportner jportner jportner approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Osquery Security Solution Osquery feature release_note:skip Skip the PR/issue when compiling release notes Team:Asset Management Security Asset Management Team v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrykkopycinski @elasticmachine @kibanamachine @jportner @james-elastic