Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] replace IFieldType with IndexPatternField #110245

Merged
merged 4 commits into from
Aug 30, 2021
Merged

[Maps] replace IFieldType with IndexPatternField #110245

merged 4 commits into from
Aug 30, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 26, 2021

Fixes #109310

Replace IFieldType with IndexPatternField

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Aug 26, 2021
@nreese nreese requested a review from thomasneirynck August 26, 2021 14:21
@nreese nreese requested a review from a team as a code owner August 26, 2021 14:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Aug 30, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 3.1MB 3.1MB +5.0B
Unknown metric groups

References to deprecated APIs

id before after diff
maps 704 383 -321

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thomasneirynck
thomasneirynck approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@nreese nreese added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 30, 2021
@nreese nreese merged commit 4cf722f into elastic:master Aug 30, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 30, 2021
@nreese @kibanamachine
[Maps] replace IFieldType with IndexPatternField (elastic#110245)
5b64de2 
* [Maps] replace IFieldType with IndexPatternField

* clean up imports

* import from public

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Aug 30, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 30, 2021
@kibanamachine @nreese
[Maps] replace IFieldType with IndexPatternField (#110245) (#110518)
23eae30 
* [Maps] replace IFieldType with IndexPatternField

* clean up imports

* import from public

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Nathan Reese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] Remove deprecated IFieldType
4 participants
@nreese @elasticmachine @kibanamachine @thomasneirynck