Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAC][Observability] Fix empty actions popover button #110015

Merged
merged 1 commit into from
Aug 25, 2021
Merged

[RAC][Observability] Fix empty actions popover button #110015

merged 1 commit into from
Aug 25, 2021

Conversation

semd
Copy link
Contributor

@semd semd commented Aug 25, 2021

Summary

There was a bug when the user had no actions allowed, the button was still appearing with empty options:
image

Button hidden if no actions allowed:
Captura de Pantalla 2021-08-25 a les 10 51 00

@semd semd added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 labels Aug 25, 2021
@semd semd self-assigned this Aug 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@semd semd enabled auto-merge (squash) August 25, 2021 08:57
@angorayc angorayc requested review from angorayc and removed request for angorayc August 25, 2021 09:26
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 568.4KB 568.4KB +52.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

@semd semd merged commit c34cbbc into elastic:master Aug 25, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 25, 2021
@semd @kibanamachine
fix empty actions popover button (elastic#110015)
b29c538
@kibanamachine kibanamachine mentioned this pull request Aug 25, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 25, 2021
@semd @kibanamachine
fix empty actions popover button (elastic#110015)
e5dae9c
@kibanamachine kibanamachine mentioned this pull request Aug 25, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 25, 2021
@kibanamachine @semd
fix empty actions popover button (#110015) (#110031)
8ebbac7 
Co-authored-by: Sergi Massaneda <[email protected]>
kibanamachine added a commit that referenced this pull request Aug 25, 2021
@kibanamachine @semd
fix empty actions popover button (#110015) (#110030)
304ccc4 
Co-authored-by: Sergi Massaneda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees

@semd semd

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@semd @elasticmachine @kibanamachine @angorayc