Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases][Observability] Disabling sync alerts for observability #109929

Merged

Conversation

jonathan-buttner
Copy link
Contributor

@jonathan-buttner jonathan-buttner commented Aug 24, 2021

Issue: #109940

This PR adds the ability to disable the sync alerts toggle in the UI within the observability context for cases. This is to address a bug where the sync alerts toggle is being shown when it shouldn't.

Observability

image

Security Solution

image

@jonathan-buttner jonathan-buttner added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Feature:Cases Cases feature v7.15.0 v7.16.0 labels Aug 24, 2021
@jonathan-buttner jonathan-buttner requested a review from a team as a code owner August 24, 2021 19:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, and tested with you over zoom

@jonathan-buttner jonathan-buttner linked an issue Aug 24, 2021 that may be closed by this pull request
@jonathan-buttner jonathan-buttner added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 24, 2021
@jonathan-buttner jonathan-buttner enabled auto-merge (squash) August 24, 2021 19:57
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 582.6KB 582.7KB +109.0B
observability 568.0KB 568.0KB +18.0B
total +127.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jonathan-buttner jonathan-buttner merged commit cc9912c into elastic:master Aug 24, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 24, 2021
…ic#109929)

* Disabling sync alerts for observability

* Adding unit tests
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 24, 2021
…ic#109929)

* Disabling sync alerts for observability

* Adding unit tests
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.15
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 25, 2021
…) (#109972)

* Disabling sync alerts for observability

* Adding unit tests

Co-authored-by: Jonathan Buttner <[email protected]>
kibanamachine added a commit that referenced this pull request Aug 25, 2021
…) (#109973)

* Disabling sync alerts for observability

* Adding unit tests

Co-authored-by: Jonathan Buttner <[email protected]>
@jonathan-buttner jonathan-buttner deleted the hide-sync-alerts-obs branch August 25, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cases][Observability] Sync alerts toggle is shown
4 participants