Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused deprecated api #109921

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Remove unused deprecated api #109921

merged 2 commits into from
Aug 25, 2021

Conversation

stacey-gammon
Copy link
Contributor

The API docs system now tracks which deprecated APIs are safe to remove.

Testing this PR out to see if it's working.

@stacey-gammon stacey-gammon requested a review from a team as a code owner August 24, 2021 19:11
@stacey-gammon stacey-gammon added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.16.0 labels Aug 24, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2981 2980 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 790.8KB 790.8KB -26.0B
Unknown metric groups

API count

id before after diff
data 3498 3497 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Dosant
Dosant approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool 🚀

@stacey-gammon stacey-gammon added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 25, 2021
@stacey-gammon stacey-gammon merged commit 26c574d into elastic:master Aug 25, 2021
@kibanamachine kibanamachine mentioned this pull request Aug 25, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 25, 2021
@stacey-gammon @kibanamachine
Remove unused deprecated api (elastic#109921)
0f832f4 
* remove unused deprecated apis

* Update legacy docs
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 25, 2021
@kibanamachine @stacey-gammon
Remove unused deprecated api (#109921) (#110089)
121d28c 
* remove unused deprecated apis

* Update legacy docs

Co-authored-by: Stacey Gammon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stacey-gammon @kibanamachine @Dosant