Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Remove spacesOss plugin (#109258) #109649

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

jportner
Copy link
Contributor

Backports the following commits to 7.x:

# Conflicts:
#	.eslintrc.js
#	.github/CODEOWNERS
#	src/plugins/dashboard/kibana.json
@jportner jportner enabled auto-merge (squash) August 23, 2021 13:23
@pgayvallet
Copy link
Contributor

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
savedObjectsManagement 79 82 +3
spaces 240 237 -3
spacesOss 4 - -4
total -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 221.4KB 221.3KB -172.0B
savedObjectsManagement 140.8KB 140.7KB -81.0B
spaces 265.2KB 265.2KB +1.0B
triggersActionsUi 1.6MB 1.6MB -32.0B
total -284.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
savedObjectsManagement 34.3KB 39.1KB +4.8KB
spaces 42.3KB 35.8KB -6.5KB
spacesOss 2.5KB - -2.5KB
triggersActionsUi 89.3KB 89.3KB -33.0B
total -4.3KB
Unknown metric groups

API count

id before after diff
savedObjectsManagement 96 0 -96
spaces 110 203 +93
spacesOss 77 - -77
triggersActionsUi 239 238 -1
total -81

API count missing comments

id before after diff
savedObjectsManagement 85 0 -85
spaces 4 20 +16
spacesOss 10 - -10
triggersActionsUi 230 229 -1
total -80

Non-exported public API item count

id before after diff
spaces 0 1 +1

References to deprecated APIs

id before after diff
savedObjectsManagement 20 0 -20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner merged commit 492de4e into elastic:7.x Aug 23, 2021
@jportner jportner deleted the backport/7.x/pr-109258 branch August 23, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants