[RAC] Toolbar total number units fixed #109252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semd
added
bug
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: cc @semd |
andrew-goldstein
approved these changes
Aug 19, 2021
There was a problem hiding this comment.
Thanks for the fix @semd
Tested locally in alerts and events views
LGTM
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 20, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 20, 2021
kibanamachine
added a commit
that referenced
this pull request
Aug 20, 2021
Co-authored-by: Sergi Massaneda <[email protected]>
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
removed
the
backport missing
kibanamachine
added a commit
that referenced
this pull request
Aug 24, 2021
Co-authored-by: Sergi Massaneda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
unitproperty to allow customization at timeline top level, and default it only in one place to "alerts" if not passed.Now in hosts/events it shows the correct "events" unit:
In the Alerts table (Security solutions and Observability) it still shows "alerts", as expected.
Checklist
Delete any items that are not applicable to this PR.