Remove LegacyRequest type from Core public API #109243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
chore
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
jportner
approved these changes
Aug 19, 2021
mshustov
added
the
auto-backport
pgayvallet
approved these changes
Aug 19, 2021
💚 Build SucceededMetrics [docs]Unknown metric groupsAPI count
API count missing comments
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 19, 2021
* remove LegacyRequest from public API * remove LegacyRequest from Security plugin API * update docs * remove an obsolete comment
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 19, 2021
* remove LegacyRequest from public API * remove LegacyRequest from Security plugin API * update docs * remove an obsolete comment Co-authored-by: Mikhail Shustov <[email protected]>
This was referenced Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes
LegacyRequesttype from the Core public API contracts.It shouldn't affect plugin developers - after the legacy platform removal, Kibana plugins do not have access to the Hapi
Requestobject.part of #77997
Plugin API changes
Core API doesn't accept
LegacyRequestinBasePathandScopeableRequettypes anymore.