Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused chrome APIs #109204

Merged
merged 5 commits into from
Aug 19, 2021
Merged

Remove unused chrome APIs #109204

merged 5 commits into from
Aug 19, 2021

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Aug 19, 2021 •
edited
Loading

Summary

Fix #109154

Remove the following unused chrome APIs:

  • setBrand
  • getBrand$
  • addApplicationClass
  • removeApplicationClass
  • getApplicationClasses$ (was used by the rendering service but doing nothing as the associated setters were unused)
  • setAppTitle

Checklist

@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture v7.16.0 labels Aug 19, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 424.8KB 423.6KB -1.2KB
Unknown metric groups

API count

id before after diff
core 2260 2247 -13

API count missing comments

id before after diff
core 1006 999 -7

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet marked this pull request as ready for review August 19, 2021 13:06
@pgayvallet pgayvallet requested a review from a team as a code owner August 19, 2021 13:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 19, 2021
@pgayvallet pgayvallet merged commit e88d77b into elastic:master Aug 19, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 19, 2021
@pgayvallet @kibanamachine
Remove unused chrome APIs (elastic#109204)
0d98f92 
* remove unused chrome APIs

* update generated doc

* fix tests

* fix tests bis
@kibanamachine kibanamachine mentioned this pull request Aug 19, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 20, 2021
@kibanamachine @pgayvallet
Remove unused chrome APIs (#109204) (#109254)
ffad23b 
* remove unused chrome APIs

* update generated doc

* fix tests

* fix tests bis

Co-authored-by: Pierre Gayvallet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused chrome functionality
4 participants
@pgayvallet @kibanamachine @elasticmachine @mshustov