-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task Manager][8.0] Added migrations to savedObject Ids for "actions:* and "alerting:*" task types #109180
Conversation
…* and "alerting:*" task types
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One recommendation but this is great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to merge into feature branch! We do have functional tests for alerting and actions migrations....could we add a functional test for these migrations as well?
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / Plugin Functional Tests.x-pack/test/plugin_api_integration/test_suites/task_manager/migrations·ts.task_manager migrations 8.0.0 migrates actions tasks from legacy id to saved object idsStandard Out
Stack Trace
Kibana Pipeline / general / X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts.alerting api integration security and spaces enabled Alerts legacy alerts alerts superuser at space1 should schedule actions on legacy alertsStandard Out
Stack Trace
Kibana Pipeline / general / X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts.alerting api integration security and spaces enabled Alerts legacy alerts alerts superuser at space1 should schedule actions on legacy alertsStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: cc @YulNaumenko |
@elasticmachine merge upstream |
…migration-for-action-alert-types
* [Alerting] [8.0] Prepare for making alerting saved objects sharecapable (#109990) * [Alerting] [8.0] Prepare for making alerting saved objects sharecapable * removed v8 check * removed link * added no op migration * fixed name Co-authored-by: Kibana Machine <[email protected]> * [Actions] [8.0] Prepare for making action saved objects sharecapable. (#109756) * [Actions] [8.0] Prepare for making action saved objects sharecapable. * added more tests * made it compatible to merge to 7.x * fixed due to comments * fixed tests * added tests * fixed tests * fixed due to comments * added no-opactions migration * fixed test * [Task Manager][8.0] Added migrations to savedObject Ids for "actions:* and "alerting:*" task types (#109180) * [Task Manager][8.0] Added migrations to savedObject Ids for "actions:* and "alerting:*" task types * fixed due to comments * fixed typo * added more tests * added unit test * added func test * added func tests * fixed test Co-authored-by: Kibana Machine <[email protected]> * fixed merge * fixed legacy tests * fixed tests * fixed eslint * Update migrations.ts fixed action task * fixed due to comments Co-authored-by: Kibana Machine <[email protected]>
Note: this PR will be merged to FB (because of failing functional tests)
Summary
Resolves #108084
Added migrations for task documents with task types for 'actions:..' and 'alerting:..' to have the new Ids based on generated by
SavedObjectsUtils.getConvertedObjectId
functionChecklist
Delete any items that are not applicable to this PR.