-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ftr] rework ciGroup validation to remove JOBS.yml and avoid duplication #109149
Conversation
Both this PR build and the latest master build reported 73,891 tests |
Pinging @elastic/kibana-operations (Team:Operations) |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/management/_runtime_fields·js.management runtime fields "before all" hook in "runtime fields"Standard Out
Stack Trace
Kibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/management/_runtime_fields·js.management runtime fields "after all" hook: afterAll in "runtime fields"Standard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
…ion (elastic#109149) Co-authored-by: spalger <[email protected]> # Conflicts: # .ci/jobs.yml # test/scripts/jenkins_code_coverage.sh
…ion (elastic#109149) Co-authored-by: spalger <[email protected]> # Conflicts: # .ci/jobs.yml # test/scripts/jenkins_code_coverage.sh
…ion (elastic#109149) Co-authored-by: spalger <[email protected]> # Conflicts: # .ci/jobs.yml # test/scripts/jenkins_code_coverage.sh
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
…ion (#109149) (#109326) Co-authored-by: spalger <[email protected]> # Conflicts: # .ci/jobs.yml # test/scripts/jenkins_code_coverage.sh Co-authored-by: Kibana Machine <[email protected]>
…ion (#109149) (#109324) Co-authored-by: spalger <[email protected]> # Conflicts: # .ci/jobs.yml # test/scripts/jenkins_code_coverage.sh Co-authored-by: Kibana Machine <[email protected]>
…ion (#109149) (#109325) Co-authored-by: spalger <[email protected]> # Conflicts: # .ci/jobs.yml # test/scripts/jenkins_code_coverage.sh Co-authored-by: Kibana Machine <[email protected]>
@wayneseymour pointed out that the error message when tests are missing their ciGroup is pointing to an old
tasks/functional_test_groups.js
file. While looking how to fix this I realized that we aren't running these checks consistently between the root and x-pack tests, and that we had the list of ciGroups in multiple places. This updates the test scripts to use a single script (helpful for reproducing these results locally) and replaces the oldJOBS.yml
file with a.ci/ci_groups.yml
file which is just for listing the ciGroups which we run. There is still plenty of duplication in the Jenkins pipeline files but I hope that @brianseeders will be able to use this file (or something similar) to determine which ciGroups we should run in Buildkite (or maybe we'll just prioritize getting rid of ciGroups completely).