Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC] Fix scrolling on Obs alerts table #109139

Merged
merged 5 commits into from
Aug 24, 2021
Merged

[RAC] Fix scrolling on Obs alerts table #109139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d6c66aa
Fix scrolling on obs alerts table and default to 50 items per page
Kerry350 Aug 18, 2021
de896ac
Merge remote-tracking branch 'upstream/master' into 108188-obs-alerts…
Kerry350 Aug 20, 2021
38be6e5
Change itemsPerPage at the store level
Kerry350 Aug 23, 2021
21dee82
Merge remote-tracking branch 'upstream/master' into 108188-obs-alerts…
Kerry350 Aug 23, 2021
bfe7535
Amend prop in test
Kerry350 Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,6 @@ export function AlertsTableTGrid(props: AlertsTableTGridProps) {
end: rangeTo,
filters: [],
indexNames,
itemsPerPage: 10,
itemsPerPageOptions: [10, 25, 50],
loadingText: i18n.translate('xpack.observability.alertsTable.loadingTextLabel', {
defaultMessage: 'loading alerts',
Expand Down
5 changes: 1 addition & 4 deletions x-pack/plugins/timelines/public/components/t_grid/standalone/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ const EventsContainerLoading = styled.div.attrs(({ className = '' }) => ({
const FullWidthFlexGroup = styled(EuiFlexGroup)<{ $visible: boolean }>`
overflow: hidden;
margin: 0;
min-height: 490px;
display: ${({ $visible }) => ($visible ? 'flex' : 'none')};
`;

Expand All @@ -96,7 +95,6 @@ export interface TGridStandaloneProps {
filterStatus: AlertStatus;
height?: number;
indexNames: string[];
itemsPerPage: number;
itemsPerPageOptions: number[];
query: Query;
onRuleChange?: () => void;
Expand Down Expand Up @@ -127,7 +125,6 @@ const TGridStandaloneComponent: React.FC<TGridStandaloneProps> = ({
footerText,
filterStatus,
indexNames,
itemsPerPage,
itemsPerPageOptions,
onRuleChange,
query,
Expand Down Expand Up @@ -282,7 +279,7 @@ const TGridStandaloneComponent: React.FC<TGridStandaloneProps> = ({
end,
},
indexNames,
itemsPerPage,
itemsPerPage: itemsPerPageStore,
itemsPerPageOptions,
showCheckboxes: true,
})
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/timelines/public/store/t_grid/defaults.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const tGridDefaults: SubsetTGridModel = {
indexNames: [],
isLoading: false,
isSelectAllChecked: false,
itemsPerPage: 25,
itemsPerPage: 50,
itemsPerPageOptions: [10, 25, 50, 100],
loadingEventIds: [],
selectedEventIds: {},
Expand Down
1 change: 0 additions & 1 deletion ...est/plugin_functional/plugins/timelines_test/public/applications/timelines_test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ const AppRoot = React.memo(
end: '',
footerText: 'Events',
filters: [],
itemsPerPage: 50,
itemsPerPageOptions: [1, 2, 3],
loadingText: 'Loading events',
renderCellValue: () => <div data-test-subj="timeline-wrapper">test</div>,
Expand Down