Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Monitoring] Remove angular dep from legacy shims #109132

Merged
merged 3 commits into from
Aug 26, 2021
Merged

[Stack Monitoring] Remove angular dep from legacy shims #109132

merged 3 commits into from
Aug 26, 2021

Conversation

phillipb
Copy link
Contributor

Summary

Move legacy init to a place that doesn't depend on Angular and convert injector lookup to a noop for now until we untangle more angular stuff.

@phillipb phillipb added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring v7.16.0 labels Aug 18, 2021
@phillipb phillipb requested a review from a team as a code owner August 18, 2021 16:45
@phillipb phillipb requested review from a team August 18, 2021 16:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

estermv
estermv approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@estermv estermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when the ci is green.

We still need to do some work on the react components that use the getAngularInjector, right?

x-pack/plugins/monitoring/public/legacy_shims.ts Outdated
@@ -37,10 +37,12 @@ export interface KFetchKibanaOptions {
prependBasePath?: boolean;
}

const angularNoop = () => { throw new Error('Angular has been removed.') }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that we would need to remove this when we remove Angular. Could we add a comment like TODO: remove when angular is removed to not forget it?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 757.6KB 754.5KB -3.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
monitoring 44.3KB 47.9KB +3.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@phillipb phillipb merged commit 85e1361 into elastic:master Aug 26, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 30, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 109132 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 109132 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 109132 or prevent reminders by adding the backport:skip label.

@estermv estermv mentioned this pull request Sep 2, 2021
Merged
estermv pushed a commit to estermv/kibana that referenced this pull request Sep 2, 2021
@phillipb @estermv
[Stack Monitoring] Remove angular dep from legacy shims (elastic#109132)
f5c0d15 
* Remove angular dep from legacy shims

* Fix ES lint
estermv added a commit that referenced this pull request Sep 2, 2021
@estermv @phillipb @kibanamachine
[Stack Monitoring] Remove angular dep from legacy shims (#109132) (#1…
6eb9a54 
…10958)

* Remove angular dep from legacy shims

* Fix ES lint

Co-authored-by: Phillip Burch <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 2, 2021
@matschaffer matschaffer mentioned this pull request Sep 7, 2021
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estermv estermv estermv approved these changes

Assignees
No one assigned
Labels
Epic: Stack Monitoring de-angularization Feature:Stack Monitoring release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phillipb @elasticmachine @kibanamachine @estermv