Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Removes kibana_dashboard_only_user role reference #108791

Closed

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Aug 16, 2021

Caused by elastic/elasticsearch#76507

5c53a66e8f3f04ad9b7c9cf5ae768d0adef4c91b is the first bad commit
commit 5c53a66e8f3f04ad9b7c9cf5ae768d0adef4c91b
Author: Devon Thomson <[email protected]>
Date:   Mon Aug 16 10:15:50 2021 -0400

    remove dashboard only reserved role (#76507)
    
    Removes the deprecated kibana_dashboard_only_user from the set of reserved roles in Elasticsearch as this legacy functionality is being removed from Kibana.
    
    Relates: elastic/kibana#54755.

 .../documentation/SecurityDocumentationIT.java     |  4 +--
 .../security/authz/store/ReservedRolesStore.java   | 10 ------
 .../authz/store/ReservedRolesStoreTests.java       | 39 ----------------------
 3 files changed, 2 insertions(+), 51 deletions(-)

Tyler Smalley added 2 commits August 16, 2021 14:44
@tylersmalley
Copy link
Contributor Author

cc @ThomThomson, hoping this is all needed to get the tests passing.

@ThomThomson ThomThomson force-pushed the rm-dashboard-only-user branch from 8f9c862 to e59ff16 Compare August 17, 2021 15:50
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson marked this pull request as ready for review August 17, 2021 18:28
@ThomThomson ThomThomson requested a review from a team as a code owner August 17, 2021 18:28
@ThomThomson ThomThomson added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Aug 18, 2021
@jportner
Copy link
Contributor

@ThomThomson do you still need a review on this? it looks like you already included some of the changes in #108103

@ThomThomson
Copy link
Contributor

I suppose it depends on how urgent it is to fix this failure. #108103 should also fix everything, but it will take a little longer for the reviews. Hopefully I can get the other PR reviewed and in by end of this week and we can close this one.

@tylersmalley
Copy link
Contributor Author

#108103 has been merged. Thanks @ThomThomson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants