Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating waffle icon and toggle style #108758

Merged
merged 1 commit into from
Aug 17, 2021
Merged

updating waffle icon and toggle style #108758

merged 1 commit into from
Aug 17, 2021

Conversation

katefarrar
Copy link
Contributor

Updating waffle icon to use grid and updating waffle / table toggle to use the primary button styles

Kapture 2021-08-16 at 12 13 42

Fixes https://github.com/elastic/observability-design/issues/85

@katefarrar katefarrar added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 16, 2021
@katefarrar katefarrar requested a review from a team as a code owner August 16, 2021 18:19
@katefarrar katefarrar requested a review from a team August 16, 2021 18:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

phillipb
phillipb approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.7MB 1.7MB +3.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@katefarrar katefarrar merged commit e6d446a into elastic:master Aug 17, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 17, 2021
@katefarrar @kibanamachine
updating waffle icon and toggle style (elastic#108758)
cada4bb
@kibanamachine kibanamachine mentioned this pull request Aug 17, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 17, 2021
@kibanamachine @katefarrar
updating waffle icon and toggle style (#108758) (#108816)
4791790 
Co-authored-by: Kate Farrar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipb phillipb phillipb approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@katefarrar @elasticmachine @kibanamachine @phillipb