Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add tooltip help text for Transform filter query control #108720

Merged
merged 6 commits into from
Aug 19, 2021
Merged

[ML] Add tooltip help text for Transform filter query control #108720

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d0d0be2
[ML] Add tooltip help text
qn895 Aug 12, 2021
9e32ce0
[ML] Remove unused import
qn895 Aug 16, 2021
91445d5
[ML] Update tooltip content to be clearer
qn895 Aug 16, 2021
14c1ea1
Merge branch 'master' into ml-transform-range-filter-editor
kibanamachine Aug 17, 2021
7e33871
Merge branch 'master' into ml-transform-range-filter-editor
kibanamachine Aug 17, 2021
b83ce7f
Merge branch 'master' into ml-transform-range-filter-editor
kibanamachine Aug 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions .../create_transform/components/step_define/common/filter_agg/components/filter_agg_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

import React, { useContext, useMemo } from 'react';
import { EuiFormRow, EuiSelect } from '@elastic/eui';
import { EuiFormRow, EuiIcon, EuiSelect, EuiToolTip } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';
import useUpdateEffect from 'react-use/lib/useUpdateEffect';
import { CreateTransformWizardContext } from '../../../../wizard/wizard';
Expand Down Expand Up @@ -72,10 +72,22 @@ export const FilterAggForm: PivotAggsConfigFilter['AggFormComponent'] = ({
<>
<EuiFormRow
label={
<FormattedMessage
id="xpack.transform.agg.popoverForm.filerAggLabel"
defaultMessage="Filter query"
/>
<>
<FormattedMessage
id="xpack.transform.agg.popoverForm.filerAggLabel"
defaultMessage="Filter query"
/>
<EuiToolTip
content={
<FormattedMessage
id="xpack.transform.agg.popoverForm.filerQueryAdvancedSuggestionTooltip"
defaultMessage="To add other filter query aggregations, edit the JSON config."
/>
}
>
<EuiIcon size="s" color="subdued" type="questionInCircle" className="eui-alignTop" />
</EuiToolTip>
</>
}
>
<EuiSelect
Expand Down