Home Page Solutions & Add Data Updates #108580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelMarcialis
added
Team:Core
|
@elasticmachine merge upstream |
Q: Should we consider making them fixed? When there's only 1 card, it pushes down the rest of the content, and I think it defeats the purpose of having them in the Welcome Screen. What do you think? |
I don't believe we have that option within the |
…kibana into 94205/update-home-page
|
@MichaelMarcialis, @ryankeairns What about cutting down the "Getting Started" text a bit. Add your data to get started Also, "Dev Tools" and "Stack Management" are app names and should use title caps. |
@gchaps: Good catch on the "Dev Tools" and "Stack Management" casing. I'll update. As for the add data section's suggested text, while I appreciate the brevity, I do worry that the three
|
|
Good points. How about this:
|
…home-page # Conflicts: # src/plugins/kibana_overview/public/components/overview/overview.tsx
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/management/_runtime_fields·js.management runtime fields create runtime field should create runtime fieldStandard OutStack TraceMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 16, 2021
* balance solutions * clean up solution changes * change footer button size * update management section * apply max-width to management items * remove right side items from page header * add data content update * illustration poc * add data content updates per feedback * img size and alignment * moved shared images to shared assets folder * more solutions clean up * rm unneeded import * remove references to subtitle and appDescriptions * update tests and snapshots * more test and snapshot updates * restore solution sort order * ts and jest fixes; thx catherine! * i18n fixes * use new `KibanaPageTemplateSolutionNavAvatar` comp * change solution imgs from png to svg * update tests and snapshots * rm spacer and update snapshots * account for flex margin changes in img offset * Change "Kibana" overview page text to "Analytics" * update overview icon to match hp changes * update snapshots * center justify solutions and update snapshots * update snapshots * title case dev tools and stack management * update text and snapshots * fix merge error Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 17, 2021
* balance solutions * clean up solution changes * change footer button size * update management section * apply max-width to management items * remove right side items from page header * add data content update * illustration poc * add data content updates per feedback * img size and alignment * moved shared images to shared assets folder * more solutions clean up * rm unneeded import * remove references to subtitle and appDescriptions * update tests and snapshots * more test and snapshot updates * restore solution sort order * ts and jest fixes; thx catherine! * i18n fixes * use new `KibanaPageTemplateSolutionNavAvatar` comp * change solution imgs from png to svg * update tests and snapshots * rm spacer and update snapshots * account for flex margin changes in img offset * Change "Kibana" overview page text to "Analytics" * update overview icon to match hp changes * update snapshots * center justify solutions and update snapshots * update snapshots * title case dev tools and stack management * update text and snapshots * fix merge error Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Michael Marcialis <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes a handful of layout and design updates to the homepage. Notable changes include:
EuiCardcomponents and balancing them equally.appDescriptionsandsubtitlefrom solution registries (as they are no longer used).Closes #94205.
CCing @ryankeairns, @alexfrancoeur, @AlonaNadler, @VijayDoshi. And thanks again to @cqliu1 for the help!
Checklist